Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify about "mentions", add "mention" switch #4461

Open
3 tasks
r10s opened this issue Jan 8, 2025 · 0 comments
Open
3 tasks

notify about "mentions", add "mention" switch #4461

r10s opened this issue Jan 8, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@r10s
Copy link
Member

r10s commented Jan 8, 2025

in groups, Android and iOS meanwhile optionally notify about things that are directly directed to you, even if a group is otherwise muted. we call that "mentions". these are:

  • replies to own messages
  • reactions to own messages
  • webxdc-notifications 1

there were all kind of additional discussions around these feature, this issue is about bringing desktop to the level of iOS and Android. steps needed:

  • adapt the notifiy yes-or-no logic to the new flow (flowchat here). basically, to the existing conditions, add if !isOneToOne AND isDirectedToYou and isMentionsEnabled { do_notify() }
    see eg. here and here for the logic changes on iOS

  • add a toggle that to control isMentionsEnabled to the notification settings - for screenshots see here and here

    • the strings are already there as pref_mention_notifications and pref_mention_notifications_explain
    • the toggle should default to ON
    • for storing the option, use set/get_config("ui.mute_mentions_if_muted")
  • to make the profile settings easier understandable i would avoid the double negative default of "Mute Notifications = Off" and instead go for a simple "Notifcations = ON" as default, as shown on the screenshots linked above. that would also be more logic with the following "Mentions" toggle, that then can be disabled when notifications are disabled. but that point is not really a blocker, but would also help on unify settings

finally, there is no urgency in this issue :) cc @adbenitez - please amend if i forgot something

Footnotes

  1. webxdc-notifications are currently always regarded as being a direct mention, so more important than the noise otherwise happening in groups, see discussions offline and eg. at https://github.com/deltachat/deltachat-android/pull/3456

@r10s r10s added the enhancement New feature or request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant