Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Build website with nix" #903

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Reapply "Build website with nix" #903

merged 2 commits into from
Jun 4, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Jun 3, 2024

No description provided.

Copy link

github-actions bot commented Jun 3, 2024

Check out the page preview at https://staging.delta.chat/903/en/

Copy link
Contributor

@missytake missytake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we can close #902 as well with this?

Copy link
Contributor

@hagenest hagenest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still bullish about nix, although I'm not 100% what it does better in this specific case :D

@link2xt
Copy link
Contributor Author

link2xt commented Jun 4, 2024

#902 is a bit independent, I can use nix instead but the issue is that readme tells you to install jekyll but then does not actually use installed jekyll because bundler installs another copy.

@link2xt link2xt merged commit 63adee3 into master Jun 4, 2024
2 checks passed
@link2xt link2xt deleted the link2xt/reapply-nix branch June 4, 2024 11:59
@link2xt
Copy link
Contributor Author

link2xt commented Jun 4, 2024

still bullish about nix, although I'm not 100% what it does better in this specific case :D

I don't really care if nix is used by CI, but want to be able to run nix build to get a website copy locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants