-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Build website with nix" #901
Conversation
This reverts commit 0d1937e.
Check out the page preview at https://staging.delta.chat/901/en/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works although the securejoin did not work and the echo bot sent back an undecrsptable message but afterwards it worked.
How echobot is related to deltachat-pages? |
If 0 unix timestamp is a problem, better use |
Doesn't help, and leaving out -t doesn't help either. The timestamp is still set to In general I think using nix for this is not a good idea, as only half of the responsible people can debug nix builds locally. Or why did we introduce it? It worked before, no? #819 doesn't point to a bug which was fixed by it, it only mentions that it makes sure that developers use the same jekyll version as the CI, but as some of us still don't use nix this doesn't really hold. |
I'll merge this for now as it fixes the issue, we can later revert it and fix it differently if we want to keep using nix. |
Is this timestamp needed for anything? |
currently we use it for deleting old builds on staging, see https://github.com/deltachat/sysadmin/issues/167. |
I just tested with #903, here is the result:
Leaving out |
Let's see if this fixes #898.