-
Notifications
You must be signed in to change notification settings - Fork 27
CP-12230 DVP Record size validation changes for setting ZFS record size #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. I would suggest adding unit test cases for the validations.
tools/src/main/python/dlpx/virtualization/_internal/validation_schemas/plugin_schema.json
Show resolved
Hide resolved
tools/src/main/python/dlpx/virtualization/_internal/validation_schemas/plugin_schema.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* Configure Mend for GitHub.com (#543) * Add .whitesource configuration file * Configure Mend for GitHub.com --------- Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Shibasish Nandi <[email protected]> * CP-12279 Documentation for ZFS record size change (#554) * CP-12230 DVP Record size validation changes for setting ZFS record size (#556) * CP-12230 DVP Record size validation changes for setting ZFS record size * CP-12367 Record size validation - Bump DVP version (#558) * CP-12377 Record size validation - DVP version documentation (#560) Record size validation - DVP version documentation --------- Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Shibasish Nandi <[email protected]>
…ze (delphix#556) * CP-12230 DVP Record size validation changes for setting ZFS record size
Problem
DVP Record size schema validation changes for setting ZFS record size
CP-12230
Solution
Added schema validation in plugin_schema.json to check if the field "recordSizeInKB" is of type "integer".
Explanation of the change:
Here in this case the normal validation like below won't work :
"recordSizeInKB": { "type" : "integer" }
In this case, we need to retrieve the properties of recordSizeInKB to get the type and then validate it.
Testing Done
Manual:


Executed dvp --verbose build --dev for correct schema for both linkedSourceDefinition and virtualSourceDefinition.
Executed dvp --verbose build --dev for inavlid schema for both linkedSourceDefinition and virtualSourceDefinition.


Executed dvp --verbose build --dev for schema without "recordSizeInKB" field in schema.

Unit test:


Unit test execution after adding new test cases :
Blackbox tests:
virtualization_sdk APPDATA_SDK_UBUNTU20_DIRECT_RHEL79
virtualization_sdk APPDATA_SDK_WIN10_STAGED_WIN2019