CP-12230 DVP Record size validation changes for setting ZFS record size (delphix#556)

* CP-12230 DVP Record size validation changes for setting ZFS record size

Author: rakshandabhat

tools/src/main/python/dlpx/virtualization/_internal/validation_schemas/plugin_schema.json

@@ -166,6 +166,15 @@
        "required": ["nameField", "identityFields"],
        "nameField": { "type": "string" },
        "identityFields": { "type": "array", "minItems": 1, "items": { "type": "string" } }
+    },
+    "recordSizeObject": {
+      "type": "object",
+      "properties": {
+          "properties": {
+              "properties": {
+              "recordSizeInKB" : {"properties": {"type": {"enum" : ["integer"]}}}}
+          }
+      }
     }
   },
   "type": "object",
@@ -200,10 +209,24 @@
       ]
     },
     "virtualSourceDefinition": {
-      "$ref": "#/definitions/jsonSchema"
+      "allOf": [
+        {
+          "$ref": "#/definitions/jsonSchema"
+        },
+        {
+          "$ref": "#/definitions/recordSizeObject"
+        }
+      ]
     },
     "linkedSourceDefinition": {
-      "$ref": "#/definitions/jsonSchema"
+      "allOf": [
+        {
+          "$ref": "#/definitions/jsonSchema"
+        },
+        {
+          "$ref": "#/definitions/recordSizeObject"
+        }
+      ]
     },
     "snapshotDefinition": {
       "$ref": "#/definitions/jsonSchema"

tools/src/test/python/dlpx/virtualization/_internal/test_schema_validator.py

@@ -356,3 +356,56 @@ def test_bad_type_in_array(schema_file):
         message = err_info.value.message
         assert ("'strings' is not valid under any of the given schemas"
                 in message)
+
+    @staticmethod
+    @pytest.mark.parametrize('linked_source_definition',
+                             [{
+                                 'type': 'object',
+                                 'additionalProperties': False,
+                                 'properties': {
+                                     'recordSizeInKB': {
+                                         'type': 'string'
+                                     }
+                                 }
+                             }])
+    def test_bad_recordSizeInKB_type_string(schema_file):
+        with pytest.raises(exceptions.SchemaValidationError) as err_info:
+            validator = SchemaValidator(schema_file, const.PLUGIN_SCHEMA)
+            validator.validate()
+
+        message = err_info.value.message
+        assert "'string' is not one of ['integer']" in message
+
+    @staticmethod
+    @pytest.mark.parametrize('virtual_source_definition',
+                             [{
+                                 'type': 'object',
+                                 'additionalProperties': False,
+                                 'properties': {
+                                     'recordSizeInKB': {
+                                         'type': 'array'
+                                     }
+                                 }
+                             }])
+    def test_bad_recordSizeInKB_type_array_virtual(schema_file):
+        with pytest.raises(exceptions.SchemaValidationError) as err_info:
+            validator = SchemaValidator(schema_file, const.PLUGIN_SCHEMA)
+            validator.validate()
+
+        message = err_info.value.message
+        assert "'array' is not one of ['integer']" in message
+
+    @staticmethod
+    @pytest.mark.parametrize('virtual_source_definition',
+                             [{
+                                 'type': 'object',
+                                 'additionalProperties': False,
+                                 'properties': {
+                                     'recordSizeInKB': {
+                                         'type': 'integer'
+                                     }
+                                 }
+                             }])
+    def test_recordSizeInKB_type_virtual(schema_file):
+        validator = SchemaValidator(schema_file, const.PLUGIN_SCHEMA)
+        validator.validate()