Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #742

Merged
merged 171 commits into from
Jul 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
171 commits
Select commit Hold shift + click to select a range
9e49387
First steps for a hdf5 file support for the chic* modules
joachimwolff Oct 22, 2020
9bbdea8
impovment in hicAggregate
Dec 3, 2020
57e1762
improvement in structure/saving outputs and clustering. mode intra-ch…
Dec 4, 2020
24fa0aa
add --noNorm in hicCompareMatrices
lldelisle Dec 8, 2020
89d9eb2
fixed --perChr
Dec 14, 2020
7b0de05
wrapped up the changes on perChr
Dec 15, 2020
93bc33e
Fix #635 (#637)
LeilyR Dec 15, 2020
acb36b3
lint
Dec 15, 2020
ef7f1d3
more lint
Dec 15, 2020
b18d042
fixed a bug. plot_diagnostic_heatmaps is not working
Dec 15, 2020
b1e3371
lint
Dec 15, 2020
889aabd
heatmap fix
Dec 15, 2020
b84de20
added an option to allow for keeping or removing the outliers. Added …
Dec 17, 2020
8220a61
lint
Dec 17, 2020
e9d3535
added keep_outlier and fixed the failed tests
Dec 22, 2020
4210fa4
updated the help message for keep_outlier
Dec 22, 2020
f29e95e
Merge pull request #643 from deeptools/aggregate_fix
LeilyR Dec 23, 2020
0e8f470
Merge branch 'develop' into chicHDF
joachimwolff Jan 4, 2021
7b9923a
continue implementing hdf for chic
joachimwolff Jan 4, 2021
de4daf7
target and signficant data write to hdf5
joachimwolff Jan 5, 2021
5dcfda1
significant hdf5 files
joachimwolff Jan 7, 2021
6d7c57e
target file as hdf5 for chicSignificantInteractions
joachimwolff Jan 7, 2021
b3cbfa5
write correct file for targets in dual mode
joachimwolff Jan 8, 2021
348ecd9
Implementing read and processing of hdf stored data
joachimwolff Jan 8, 2021
6d552e8
aggregate hdf5 file
joachimwolff Jan 9, 2021
e2d2a15
out commenting old write method
joachimwolff Jan 9, 2021
4daf094
start to implement hdf support
joachimwolff Jan 9, 2021
3e36f5e
Increased version number to 3.7dev
joachimwolff Jan 9, 2021
142b685
continue work
joachimwolff Jan 10, 2021
0ddd124
Fix non unique name of genes and doubled gene names from different ma…
joachimwolff Jan 12, 2021
7f4e55d
correct hdf output
joachimwolff Jan 12, 2021
f0182aa
Fix import of hdf from significant
joachimwolff Jan 12, 2021
5230295
Add try/except
joachimwolff Jan 12, 2021
506a28e
continue write of differential hdf
joachimwolff Jan 13, 2021
094198e
fix write out of differential results to hdf
joachimwolff Jan 13, 2021
bd27765
start to implement hdf support
joachimwolff Jan 14, 2021
ed9d28e
Extend help text and potential bug fix for #655
joachimwolff Jan 18, 2021
ae8ca0e
continue to implement hdf support for chic modules
joachimwolff Jan 19, 2021
06898e0
read of interaction data for plotting successful
joachimwolff Jan 20, 2021
fddc7fc
continue development of hdf support
joachimwolff Jan 21, 2021
5cbe61f
output to tar.gz file
joachimwolff Jan 22, 2021
5dc62c6
plotting with interaction, significant and differntial works in princ…
joachimwolff Jan 25, 2021
bd52dea
differential fix
joachimwolff Jan 25, 2021
465259e
Adding export function for hdf data, fixing chicSignificant to operat…
joachimwolff Jan 27, 2021
bbc916e
Export of data to text files in gzip files continued
joachimwolff Jan 28, 2021
870568f
liniting
joachimwolff Jan 28, 2021
e7893dc
add a test
lldelisle Feb 19, 2021
09961e7
Add bigwig support, however, it is crashing to write it to a tar.gz
joachimwolff Mar 1, 2021
5633f2f
writing files to tmp than packing this as tar and delete the temp. Ba…
joachimwolff Mar 2, 2021
39c0a37
Adding option to extract relative-interactions, p-value, x-fold or ra…
joachimwolff Mar 2, 2021
32eb2d7
liniting
joachimwolff Mar 3, 2021
f28567a
Merge pull request #645 from lldelisle/noNormInOp
joachimwolff Mar 3, 2021
2d00a47
Implemnting the support for multiple restriction sites. #659
joachimwolff Mar 3, 2021
0dadb7f
Extending test case hicFindRestSite
joachimwolff Mar 3, 2021
751460d
Adding test data for hicFindRestSite
joachimwolff Mar 3, 2021
5685162
Implementing for hicBuildMatrix the restriction cut file limitations …
joachimwolff Mar 3, 2021
43ebff1
add hicTADClassifier
AlbertLidel Mar 12, 2021
9775f17
update requirements
AlbertLidel Mar 12, 2021
1207a7e
fix roc output and update docs
AlbertLidel Mar 12, 2021
4c60a9c
Renamed hicTrainClassifier to hicTrainTADClassifier, added bin files;…
joachimwolff Mar 15, 2021
d1f50dd
Merge branch 'develop' into albert_TAD
joachimwolff Mar 15, 2021
faa6cce
add missing files
AlbertLidel Mar 18, 2021
c3b3ad6
rebuild gitignore
AlbertLidel Mar 18, 2021
5115e17
move lib files
AlbertLidel Mar 18, 2021
fb11d29
fix linting
AlbertLidel Mar 18, 2021
8a6accb
fix docs
AlbertLidel Mar 18, 2021
9c5268b
fix linting 2
AlbertLidel Mar 18, 2021
2b03afa
fix linting 3
AlbertLidel Mar 18, 2021
adc63c7
Merge pull request #692 from AlbertLidel/albert_TAD
joachimwolff Mar 18, 2021
fd52b1f
Bringing alberts tad classification into shape
joachimwolff Mar 18, 2021
d273b47
Merge branch 'albert_TAD' of github.com:deeptools/HiCExplorer into al…
joachimwolff Mar 18, 2021
50ab75c
Bug fixing and performance improvements by loading only one chromosom…
joachimwolff Mar 22, 2021
03c16ad
Predicting per chromosome implemented.
joachimwolff Mar 22, 2021
394fff5
Fixing chr-prefix issue
joachimwolff Mar 22, 2021
bb4cbe1
hicFindTADs: change computation with cool files per chromosome and no…
joachimwolff Mar 23, 2021
b7a6ed8
Support for cool files and chromosomes, fixing bugs, adding features.…
joachimwolff Mar 24, 2021
5e08070
bug fixing hicFindTADs
joachimwolff Mar 24, 2021
abd7e50
adjust docstring of compute_distance_mean
lldelisle Mar 31, 2021
43920fa
allowToPlotDistVsCounts on specific regions
lldelisle Mar 31, 2021
19bae63
use it in main
lldelisle Mar 31, 2021
1b43d79
fix typo
lldelisle Mar 31, 2021
691ea09
check there is at least one region
lldelisle Mar 31, 2021
dfc538b
add r for the tad_line
lldelisle Mar 31, 2021
e3e2764
use triple quote
lldelisle Mar 31, 2021
d3e11be
fix doctest
lldelisle Mar 31, 2021
c3d4587
remove doctest waiting for hicmatrix release
lldelisle Mar 31, 2021
7721eed
forgot blank line
lldelisle Mar 31, 2021
4a75902
commiting old changes
joachimwolff Apr 8, 2021
cd2045f
hic to cool file only, increase version number, debug info activated
joachimwolff Apr 17, 2021
abfa8c8
chicSiginficant bug fix
joachimwolff Apr 24, 2021
a3ac3f0
add function to export only one gene
joachimwolff Apr 24, 2021
fcddc0b
Add support for single bed file, bug fixes for support to export per …
joachimwolff Apr 24, 2021
341a89d
Implementing no tar.gz for chicExportDate in case a single gene is wr…
joachimwolff Apr 26, 2021
24e14ce
Fixing wrong handling of the aggregation
joachimwolff May 5, 2021
a3edf65
implementing more metadata usage
joachimwolff May 5, 2021
a4dcb9b
bug fixes and linting
joachimwolff May 6, 2021
d7a75b8
Remove debug messages
joachimwolff May 6, 2021
92ef9c2
Fixing a bug to remove multiple chromosomes at once
joachimwolff May 11, 2021
9d557a2
add new columns to output text of hicPlotDistVsCounts
lldelisle Jun 1, 2021
01638bc
fix/add tests for hicPlotDistvsCounts
lldelisle Jun 1, 2021
2b1f239
remove Bio.Alphabet
lldelisle Jun 1, 2021
a6338db
fix matplotlib name in pip dependencies
lldelisle Jun 7, 2021
7f97f89
Adding test data for hicValidateLocations
joachimwolff Jun 22, 2021
8479fa2
Validate locations for 2D data stored in cool files. Adding test case
joachimwolff Jun 22, 2021
0f4a4f7
Add test data for 2D text hicConvertFormat
joachimwolff Jun 22, 2021
009cf17
Add 2d text import and hicpro export; add test cases
joachimwolff Jun 22, 2021
46c9b83
Merge branch 'develop' into chicHDF
joachimwolff Jun 22, 2021
864e947
Output Ranksum statistics
dawe Jun 22, 2021
92e0d86
fix a bug that prevented stats to be printed
dawe Jun 23, 2021
2d7c134
Removing old test data of chicViewpoint
joachimwolff Jun 23, 2021
69dcb11
Bug fixing chicViewpoint: closes a bug causing a crash if the number …
joachimwolff Jun 23, 2021
9b272d8
Exchanging test data for chic-* modules
joachimwolff Jun 24, 2021
2a2424a
Replace test cases for chic-* modules, linting and minor bug fixes. M…
joachimwolff Jun 24, 2021
e5d46a6
Add new test data and test cases for chicExportData
joachimwolff Jun 28, 2021
03c25b2
liniting
joachimwolff Jun 28, 2021
f611e3b
liniting and bug fixes: some typos in the test cases, updating test d…
joachimwolff Jun 28, 2021
c2fe3bb
Fixing doc test
joachimwolff Jun 28, 2021
0237414
Fixing doc test
joachimwolff Jun 28, 2021
02a1f4a
Update test case number
joachimwolff Jun 28, 2021
e222394
Adding test data
joachimwolff Jun 29, 2021
64f497a
Updating tutorial to new hdf5 based file format
joachimwolff Jun 29, 2021
0eac21e
Merge pull request #729 from deeptools/chicHDF
joachimwolff Jun 29, 2021
06d550a
documentation
joachimwolff Jun 30, 2021
e608596
Merge branch 'chicHDF' into develop
joachimwolff Jun 30, 2021
6a8e7cc
Merge branch 'develop' into plotDistVsCounts
joachimwolff Jun 30, 2021
75ba115
Merge pull request #696 from lldelisle/plotDistVsCounts
joachimwolff Jun 30, 2021
1158a68
Merge pull request #718 from lldelisle/biopython
joachimwolff Jun 30, 2021
778bab7
Merge pull request #728 from dawe/master
joachimwolff Jun 30, 2021
2ccde65
Updating test cases
joachimwolff Jun 30, 2021
b44b4ea
Fixing a bug in hicDifferentialTAD computation, the first boundary of…
joachimwolff Jul 1, 2021
5293ebf
Exchanging test data for hicDifferentialTest
joachimwolff Jul 7, 2021
7ec52d9
Fixing bugs in hicDifferentialTADs; issues #725 and maybe #685
joachimwolff Jul 7, 2021
d37e66f
Adding test data for hicAdjustData
joachimwolff Jul 7, 2021
315c23d
Implementing a feature to remove the inter or intra chromosomal regio…
joachimwolff Jul 7, 2021
100b2bf
Implementing new way to control the protein loop overlap for hicHyper…
joachimwolff Jul 8, 2021
945c6ea
Implementing new way to control the protein loop overlap for hicHyper…
joachimwolff Jul 8, 2021
4303fdf
Merge pull request #731 from deeptools/interintraremoval
joachimwolff Jul 8, 2021
3f01b09
Merge branch 'develop' into multiRestrictionSequence
joachimwolff Jul 8, 2021
e00b13f
First implementation of inter and intra tad computations, feature req…
joachimwolff Jul 8, 2021
32add8c
Adding test data for hicInterIntraTAD, fixing density calculation, ad…
joachimwolff Jul 9, 2021
0c5e910
adding docs for hicInterIntraTAD
joachimwolff Jul 9, 2021
3e084b9
Fixing merge
joachimwolff Jul 9, 2021
af768fe
Bug fix for hicPCA with new test data and test case. Fix #719 #716 #7…
joachimwolff Jul 10, 2021
885fd7e
Merge pull request #732 from deeptools/multiRestrictionSequence
joachimwolff Jul 10, 2021
0d8855d
Merge pull request #733 from deeptools/interintratadratio
joachimwolff Jul 10, 2021
f5e94ed
Merge pull request #735 from deeptools/pca_fixes
joachimwolff Jul 12, 2021
8d4415f
Implementing a feature to return random principal components. User re…
joachimwolff Jul 12, 2021
fe56c6e
Adding a feature to plot tads with hicPlotMatrix
joachimwolff Jul 12, 2021
063c722
Implementing a feature request for hicPlotMatrix for loops that are w…
joachimwolff Jul 12, 2021
8f2305a
Merge pull request #736 from deeptools/pca_newfeature
joachimwolff Jul 12, 2021
7c9fa3e
Typo
joachimwolff Jul 12, 2021
66c555c
Merge pull request #737 from deeptools/hicPlotMatrix_newfeatures
joachimwolff Jul 13, 2021
2b22d5c
Implementing plotNumbers feature which was outcommented for reasons. …
joachimwolff Jul 13, 2021
08dda74
Adding pdf fonttype 42 for better Adobe Illustrator support. #585
joachimwolff Jul 13, 2021
fe8870a
Fixing a bug in hicCorrect for KR and cool files. #724
joachimwolff Jul 14, 2021
a3c2801
Implementing the copy of the genome assembly information. #657
joachimwolff Jul 15, 2021
fcccff8
Fixing #720. Multiple different restriction sequences with the same d…
joachimwolff Jul 19, 2021
d2d4853
Fixing issue #618. masking of bins should be in the if-condition for …
joachimwolff Jul 19, 2021
1067d31
merge develop branch to albert tad branch
joachimwolff Jul 19, 2021
474d86b
Fixing bugs in tad prediction, get the test cases running
joachimwolff Jul 21, 2021
a39cd20
Adding default classifier, adding test case and linting
joachimwolff Jul 26, 2021
aa7d832
Changing --removeSelfLigation to --keepSelfLigation to make the remov…
joachimwolff Jul 26, 2021
056aeb2
Restoring current master branch version
joachimwolff Jul 26, 2021
7432835
Updating and bug fixing test cases. Linting.
joachimwolff Jul 26, 2021
567182c
Linting
joachimwolff Jul 26, 2021
c13c6f7
fixing test cases
joachimwolff Jul 26, 2021
0f619da
Adding test data
joachimwolff Jul 26, 2021
e030e1f
Azure pipeline reconfigure
joachimwolff Jul 26, 2021
ead8ec8
Merge pull request #741 from deeptools/albert_TAD
joachimwolff Jul 26, 2021
119a582
Adding the changes to News.rst, adding version number to chic hdf fil…
joachimwolff Jul 27, 2021
ed804ad
Fixing the docs
joachimwolff Jul 27, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
9 changes: 9 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
include hicexplorer/trained_models/10kb_model_cleanlab_proteins_obs_exp.BIN
include hicexplorer/trained_models/25kb_model_cleanlab_proteins_obs_exp.BIN
include hicexplorer/trained_models/50kb_model_cleanlab_proteins_obs_exp.BIN
include hicexplorer/trained_models/100kb_model_cleanlab_proteins_obs_exp.BIN
include hicexplorer/trained_models/10kb_model_cleanlab_proteins_range.BIN
include hicexplorer/trained_models/25kb_model_cleanlab_proteins_range.BIN
include hicexplorer/trained_models/50kb_model_cleanlab_proteins_range.BIN
include hicexplorer/trained_models/100kb_model_cleanlab_proteins_range.BIN

8 changes: 6 additions & 2 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ jobs:
displayName: doc_test_and_number_of_cases
- script: |
source activate hicexplorer
py.test hicexplorer/test/general/ --doctest-modules --capture=sys -n 4
py.test hicexplorer/test/general/ --doctest-modules --capture=sys -n 4 --ignore=hicexplorer/test/general/test_hicTADClassifier.py --ignore=hicexplorer/test/general/test_hicTrainTADClassifier.py
py.test hicexplorer/test/general/test_hicTADClassifier.py
py.test hicexplorer/test/general/test_hicTrainTADClassifier.py
displayName: pytest
- job: 'OSX'
Expand Down Expand Up @@ -86,5 +88,7 @@ jobs:
displayName: doc_test_and_number_of_cases
- script: |
source activate hicexplorer
py.test hicexplorer/test/general/ --doctest-modules --capture=sys -n 4
py.test hicexplorer/test/general/ --doctest-modules --capture=sys -n 4 --ignore=hicexplorer/test/general/test_hicTADClassifier.py --ignore=hicexplorer/test/general/test_hicTrainTADClassifier.py
py.test hicexplorer/test/general/test_hicTADClassifier.py
py.test hicexplorer/test/general/test_hicTrainTADClassifier.py
displayName: pytest
8 changes: 8 additions & 0 deletions bin/chicExportData
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-

from hicexplorer.chicExportData import main

if __name__ == "__main__":
main()

7 changes: 7 additions & 0 deletions bin/hicInterIntraTAD
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-

from hicexplorer.hicInterIntraTAD import main

if __name__ == "__main__":
main()
7 changes: 7 additions & 0 deletions bin/hicTADClassifier
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-

from hicexplorer.hicTADClassifier import main

if __name__ == "__main__":
main()
7 changes: 7 additions & 0 deletions bin/hicTrainTADClassifier
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-

from hicexplorer.hicTrainTADClassifier import main

if __name__ == "__main__":
main()
7 changes: 5 additions & 2 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@
'matplotlib', 'matplotlib.pyplot', 'matplotlib.gridspec', 'matplotlib.ticker',
'matplotlib.textpath', 'matplotlib.patches', 'matplotlib.colors', 'matplotlib.cm',
'mpl_toolkits', 'mpl_toolkits.axisartist', 'mpl_toolkits.mplot3d', 'mpl_toolkits.axes_grid1',
'Bio', 'Bio.Seq', 'Bio.Alphabet', 'pyBigWig', 'tables', 'pytables', 'future', 'past', 'past.builtins',
'Bio.Seq', 'pyBigWig', 'tables', 'pytables', 'future', 'past', 'past.builtins',
'future.utils', 'cooler', 'logging', 'unidecode', 'hic2cool', 'hicmatrix', 'hicmatrix.HiCMatrix',
'hicmatrix.lib', 'krbalancing', 'fit_nbinom', 'pybedtools', 'graphviz', 'hyperopt', 'sklearn', 'sklearn.cluster']
'hicmatrix.lib', 'krbalancing', 'fit_nbinom', 'pybedtools', 'graphviz', 'hyperopt', 'sklearn', 'sklearn.cluster',
'h5py', 'numpy.random', 'sklearn', 'sklearn.model_selection', 'matplotlib.backends', 'sklearn.preprocessing',
'matplotlib.backends.backend_agg', 'cleanlab.classification', 'imblearn.under_sampling', 'sklearn.ensemble',
'sklearn.metrics', 'sklearn.impute', 'tarfile']

for mod_name in MOCK_MODULES:
sys.modules[mod_name] = Mock()
Expand Down
37 changes: 36 additions & 1 deletion docs/content/News.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,41 @@ News and Developments
=====================


Release 3.7
-----------
**27 July 2021**

- A new TAD prediction method: `hicTADClassifier` and a method to train own classifiers `hicTrainTADClassifier`. Thanks @AlbertLidel for the design and implementation.
- New file formats for capture Hi-C modules. `chicViewpoint`, `chicSignificantInteractions`, `chicAggregateStatistic` and `chicDifferentialTest` use now HDF5 based files. A new export script `chicExportData` is provided to retrieve text files from these HDF5 files.
- Implementing a few feature requests:
- `hicPlotMatrix`: TADs can be visualized with hicPlotMatrix
- `hicAdjustMatrix` is able to remove intra- or inter-chromosomal contacts (#664, #704)
- `hicValidateLocations`: An option to validate TADs and to use additional data stored in `cool` matrices
- `hicPCA`: Adding a function to select which eigenvector should be used for the output (#669)
- `hicConvertFormat`: Adding the function to export hicpro file format and to import `2D-text` files.
- `hicFindRestSites`: Support of multiple restriction cut sequences (#659)
- `hicPlotMatrix`: Option for loop locations spanning more than one bin to define if the start, center or end should be used for plotting (#640)
- `hicInterIntraTAD`: A new script to compute the ratio of inter and intra TAD. ($404)
- `hicAggregateContacts`: Option to consider the strand orientation (#633)
- `hicAverageRegions`: Option to consider the strand orientation (#633)
- `hicCompareMatrices`: An option to not normalize the matrices before the computation. (#677, #645) Thanks @lldelisle
- `hicDifferentialTAD`: Adding rank sum statistics to the output (#728, #727). Thanks @dawe
- `hicPlotDistVsCounts`: Adding a function to plot the counts vs distance in TAD regions. (#696) Thanks @lldelisle
- Bug fixes:
- `hicCorrectMatrix`: A bug that lead to wrong correction factors for the KR correction for `cool` files (#724)
- `hicDifferentialTAD`: Solved multicore issue related to skipping data at the start and end of chromosomes (#725, #685)
- `hicHyperoptDetectLoops`: Added an option to set if the `chr` prefix should be added or removed (#723)
- `hicPCA`: Solving an issue if the region defined by the gene track is larger the region stored in the interaction matrix (#655, #710, #716, #719)
- `hicPCA`: Fixing a bug where the masking of bins was automatically applied which lead to differing matrix dimensions for the e.g. the Pearson correlation matrices (#618)
- `hicBuildMatrix`: Solving a bug if multiple restriction cut sites have the same dangling ends (#720)
- `hicBuildMatrix`: Solving a bug that the parameter `--removeSelfLigations` was always set to true. Changed parameter name to `--keepSelfLigations` to keep the functionality. If the parameter is not set, the self ligations are removed.
- `hicBuildMatrix`: If a region is specified, only the restrictionCutSite file information for that region is loaded to save memory (#646)
- `hicConvertFormat`: Fixing a bug to copy the genome annotation information in the case of a `cool` to `cool` file conversion (#657)
- `hicCorrelate`: Correcting the range of colors for the heatmap (#585)
- `hicCompartmentalization`: Fixed index bug (#635, #637) Thanks @LeilyR
- Updating `hicBuildMatrix` to be able to work with biopython versions > 1.77. Thanks @lldelisle (#691)


Release 3.6
-----------
**10 November 2020**
Expand Down Expand Up @@ -113,7 +148,7 @@ Release 3.4.2

Preprint
--------
**6 March 2020*
**6 March 2020**

The preprint of the loop detection algorithm is online via biorXiv: `<https://www.biorxiv.org/content/10.1101/2020.03.05.979096v1>`_

Expand Down
Loading