testing/btc: migrate harness to descriptor wallets #3480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the BTC testing harness from legacy wallets to descriptor wallets for compatibility with Bitcoin Core v26.0.0+ and tested up to v30.2. The migration removes legacy wallet seed management and introduces a new script for regenerating descriptor files with correct checksums.
Changes:
- Replaced legacy wallet seeds with descriptor wallet configuration files (desc-*.json)
- Changed default wallet creation to use descriptor wallets (descriptors=true by default)
- Added gen-descriptors.sh script to regenerate descriptor files when needed
- Updated documentation to reflect descriptor wallet usage and removed references to legacy seed management
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| dex/testing/btc/harness.sh | Removed legacy wallet seeds and deprecated variables; updated mining addresses for new descriptor wallets; changed default wallet type to descriptors; bumped harness version to 3 |
| dex/testing/btc/gen-descriptors.sh | New utility script to generate descriptor JSON files with correct checksums using Bitcoin Core RPC |
| dex/testing/btc/desc-alpha.json | New descriptor wallet configuration for alpha wallet with BIP44/49/84/86 support |
| dex/testing/btc/desc-beta.json | Updated descriptor wallet configuration for beta wallet |
| dex/testing/btc/desc-gamma.json | Updated descriptor wallet configuration for gamma wallet |
| dex/testing/btc/desc-delta.json | New descriptor wallet configuration for delta wallet |
| dex/testing/btc/README.md | Updated documentation to reflect four wallets, descriptor wallet usage, and added instructions for regenerating descriptor files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address review comment: document python3 dependency in script header.
JustinBeBoy
force-pushed
the
fix_testing_btc_harness
branch
from
414e1d6 to
3e24636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3475
This PR: