Skip to content

Fix type of group_by in query method #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Fix type of group_by in query method #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/Fixes-20250409-201106.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Fixes
body: Fix type of group_by in query method
time: 2025-04-09T20:11:06.83741-05:00
6 changes: 3 additions & 3 deletions dbtsl/api/graphql/client/asyncio.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ from typing import List, Optional, Self, Union
import pyarrow as pa
from typing_extensions import AsyncIterator, Unpack, overload

from dbtsl.api.shared.query_params import OrderByGroupBy, OrderByMetric, QueryParameters
from dbtsl.api.shared.query_params import GroupByParam, OrderByGroupBy, OrderByMetric, QueryParameters
from dbtsl.models import (
Dimension,
Entity,
Expand Down Expand Up @@ -84,7 +84,7 @@ class AsyncGraphQLClient:
async def query(
self,
metrics: List[str],
group_by: Optional[List[str]] = None,
group_by: Optional[List[Union[GroupByParam, str]]] = None,
limit: Optional[int] = None,
order_by: Optional[List[Union[str, OrderByGroupBy, OrderByMetric]]] = None,
where: Optional[List[str]] = None,
Expand All @@ -93,7 +93,7 @@ class AsyncGraphQLClient:
@overload
async def query(
self,
group_by: List[str],
group_by: List[Union[GroupByParam, str]],
limit: Optional[int] = None,
order_by: Optional[List[Union[str, OrderByGroupBy]]] = None,
where: Optional[List[str]] = None,
Expand Down
6 changes: 3 additions & 3 deletions dbtsl/api/graphql/client/sync.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ from typing import Iterator, List, Optional, Union
import pyarrow as pa
from typing_extensions import Self, Unpack, overload

from dbtsl.api.shared.query_params import OrderByGroupBy, OrderByMetric, QueryParameters
from dbtsl.api.shared.query_params import GroupByParam, OrderByGroupBy, OrderByMetric, QueryParameters
from dbtsl.models import (
Dimension,
Entity,
Expand Down Expand Up @@ -84,7 +84,7 @@ class SyncGraphQLClient:
def query(
self,
metrics: List[str],
group_by: Optional[List[str]] = None,
group_by: Optional[List[Union[GroupByParam, str]]] = None,
limit: Optional[int] = None,
order_by: Optional[List[Union[str, OrderByGroupBy, OrderByMetric]]] = None,
where: Optional[List[str]] = None,
Expand All @@ -93,7 +93,7 @@ class SyncGraphQLClient:
@overload
def query(
self,
group_by: List[str],
group_by: List[Union[GroupByParam, str]],
limit: Optional[int] = None,
order_by: Optional[List[Union[str, OrderByGroupBy]]] = None,
where: Optional[List[str]] = None,
Expand Down
2 changes: 2 additions & 0 deletions dbtsl/api/shared/query_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@


class GroupByType(Enum):
"""The type of a group_by, i.e a dimension or an entity."""

DIMENSION = "dimension"
ENTITY = "entity"

Expand Down
4 changes: 2 additions & 2 deletions dbtsl/client/asyncio.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ from typing import AsyncIterator, List, Optional, Union
import pyarrow as pa
from typing_extensions import Self, Unpack, overload

from dbtsl.api.shared.query_params import OrderByGroupBy, OrderByMetric, QueryParameters
from dbtsl.api.shared.query_params import GroupByParam, OrderByGroupBy, OrderByMetric, QueryParameters
from dbtsl.models import Dimension, Entity, Measure, Metric, SavedQuery
from dbtsl.timeout import TimeoutOptions

Expand Down Expand Up @@ -54,7 +54,7 @@ class AsyncSemanticLayerClient:
async def query(
self,
metrics: List[str],
group_by: Optional[List[str]] = None,
group_by: Optional[List[Union[GroupByParam, str]]] = None,
limit: Optional[int] = None,
order_by: Optional[List[Union[str, OrderByGroupBy, OrderByMetric]]] = None,
where: Optional[List[str]] = None,
Expand Down
6 changes: 3 additions & 3 deletions dbtsl/client/sync.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ from typing import Iterator, List, Optional, Union
import pyarrow as pa
from typing_extensions import Self, Unpack, overload

from dbtsl.api.shared.query_params import OrderByGroupBy, OrderByMetric, QueryParameters
from dbtsl.api.shared.query_params import GroupByParam, OrderByGroupBy, OrderByMetric, QueryParameters
from dbtsl.models import Dimension, Entity, Measure, Metric, SavedQuery
from dbtsl.timeout import TimeoutOptions

Expand Down Expand Up @@ -54,7 +54,7 @@ class SyncSemanticLayerClient:
def query(
self,
metrics: List[str],
group_by: Optional[List[str]] = None,
group_by: Optional[List[Union[GroupByParam, str]]] = None,
limit: Optional[int] = None,
order_by: Optional[List[Union[str, OrderByGroupBy, OrderByMetric]]] = None,
where: Optional[List[str]] = None,
Expand All @@ -63,7 +63,7 @@ class SyncSemanticLayerClient:
@overload
def query(
self,
group_by: List[str],
group_by: List[Union[GroupByParam, str]],
limit: Optional[int] = None,
order_by: Optional[List[Union[str, OrderByGroupBy]]] = None,
where: Optional[List[str]] = None,
Expand Down
Loading