Skip to content

Fix type of group_by in query method #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Fix type of group_by in query method #80

merged 1 commit into from
Apr 15, 2025

Conversation

DevonFulcher
Copy link
Contributor

In my last PR, I neglected to update the type information for the query method in some instances. This fixes that by allowing Union[GroupByParam, str] instead of just str for group_by params.

@DevonFulcher DevonFulcher marked this pull request as ready for review April 10, 2025 01:56
@DevonFulcher DevonFulcher requested a review from a team as a code owner April 10, 2025 01:56
serramatutu
serramatutu approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@serramatutu serramatutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wish there was some tool to automatically check if your .pyi type definitions make sense with your .py implementation.

@DevonFulcher DevonFulcher merged commit 8e317c9 into main Apr 15, 2025
4 checks passed
@DevonFulcher DevonFulcher deleted the Fix_type_of_group_by_in_query_method branch April 15, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serramatutu serramatutu serramatutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DevonFulcher @serramatutu