Skip to content

chore: bump dev-dependencies group, hold back workers-types/wrangler - #507

Merged
davidwkeith merged 2 commits into
mainfrom
claude/pr-491-40648f
Aug 22, 2026
Merged

chore: bump dev-dependencies group, hold back workers-types/wrangler#507
davidwkeith merged 2 commits into
mainfrom
claude/pr-491-40648f

Conversation

@davidwkeith

@davidwkeith davidwkeith commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

Supersedes #491, whose CI (build-test, image, integration) failed
on the same single root cause: @cloudflare/workers-types >=5.20260807.2
adds a global declare const Buffer: any (nodejs_compat ambient global).
In any package that lists both "node" and "@cloudflare/workers-types"
in its tsconfig.json types array (@dwk/cf-shims, @dwk/server,
@dwk/conformance-target), this collides with @types/node's own
Buffer typing, and every buf.toString(encoding) call in scope
(hex/base64/etc.) resolves to the zero-arg Object.prototype.toString
instead of Node's overload — a hard tsc error, not just a lint nit.

Verified with a minimal repro and by bisecting each of the 7 originally
bumped packages individually (installing each old/new combination and
re-running pnpm typecheck). The bug is present in every
@cloudflare/workers-types release up through 5.20260822.1 (checked
against npm), so it isn't a transient regression that will resolve
itself on the next patch release.

This PR takes the same dependency bump as #491 but holds back the
correlated Cloudflare trio:

  • @cloudflare/workers-types (5.20260804.1, unchanged) — carries the bug
  • wrangler (4.119.0, unchanged) — 4.120.0+ peer-depends on
    @cloudflare/workers-types@^5.20260811.1, which is inside the broken
    range
  • @cloudflare/vitest-pool-workers (0.20.2, unchanged) — pulls in the
    newer wrangler as a nested dependency

eslint, typescript-eslint, @types/node, and esbuild keep their
bumps from the original PR. @dwk/conformance-target's package.json
ends up unchanged net of both commits (its workers-types bump is held
back too), so it no longer appears in the diff.

Full local CI gate (pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test) and node scripts/release-gate.mjs pass
cleanly against this combination. All five CI checks (build-test,
image, integration, release-gate, CodeQL) are green.

Packages affected

Root package.json, @dwk/cf-shims, @dwk/deno-host, @dwk/server
(devDependency version pins only — no source changes)

Checklist

  • Read the relevant spec(s) under spec/packages/ and updated them if
    behaviour changed — not applicable, dependency version pins only
  • Added/updated colocated tests (src/*.test.ts) — not applicable, no behaviour change
  • Ran the local CI gate: pnpm lint && pnpm format:check && pnpm typecheck && pnpm build && pnpm test
  • Added a changeset (pnpm changeset) if this touches a publishable
    package — not applicable; @dwk/cf-shims and @dwk/deno-host are
    publishable, but a devDependency-only bump doesn't change their
    published artifact or warrant a version bump
  • Updated catalog.json / conformance/status.json if this adds a new
    mountable worker or changes conformance status — not applicable

dependabot Bot and others added 2 commits August 22, 2026 10:56
…ith 7 updates

Bumps the dev-dependencies group with 7 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [@cloudflare/vitest-pool-workers](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/vitest-pool-workers) | `0.20.2` | `0.21.3` |
| [@cloudflare/workers-types](https://github.com/cloudflare/workerd) | `5.20260804.1` | `5.20260816.1` |
| [eslint](https://github.com/eslint/eslint) | `10.8.0` | `10.8.1` |
| [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.66.0` | `8.67.0` |
| [wrangler](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler) | `4.119.0` | `4.123.0` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `26.1.2` | `26.2.0` |
| [esbuild](https://github.com/evanw/esbuild) | `0.28.1` | `0.28.2` |



Updates `@cloudflare/vitest-pool-workers` from 0.20.2 to 0.21.3
- [Release notes](https://github.com/cloudflare/workers-sdk/releases)
- [Changelog](https://github.com/cloudflare/workers-sdk/blob/main/packages/vitest-pool-workers/CHANGELOG.md)
- [Commits](https://github.com/cloudflare/workers-sdk/commits/@cloudflare/vitest-pool-workers@0.21.3/packages/vitest-pool-workers)

Updates `@cloudflare/workers-types` from 5.20260804.1 to 5.20260816.1
- [Release notes](https://github.com/cloudflare/workerd/releases)
- [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md)
- [Commits](https://github.com/cloudflare/workerd/commits)

Updates `eslint` from 10.8.0 to 10.8.1
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v10.8.0...v10.8.1)

Updates `typescript-eslint` from 8.66.0 to 8.67.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.67.0/packages/typescript-eslint)

Updates `wrangler` from 4.119.0 to 4.123.0
- [Release notes](https://github.com/cloudflare/workers-sdk/releases)
- [Commits](https://github.com/cloudflare/workers-sdk/commits/wrangler@4.123.0/packages/wrangler)

Updates `@types/node` from 26.1.2 to 26.2.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `esbuild` from 0.28.1 to 0.28.2
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.28.1...v0.28.2)

---
updated-dependencies:
- dependency-name: "@cloudflare/vitest-pool-workers"
  dependency-version: 0.21.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: "@cloudflare/workers-types"
  dependency-version: 5.20260812.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: "@types/node"
  dependency-version: 26.2.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: esbuild
  dependency-version: 0.28.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: eslint
  dependency-version: 10.8.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: dev-dependencies
- dependency-name: typescript-eslint
  dependency-version: 8.67.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: wrangler
  dependency-version: 4.122.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
…wrangler

@cloudflare/workers-types >=5.20260807.2 adds a global `declare const
Buffer: any` (nodejs_compat ambient global). Merged into a package's
`types` array alongside `@types/node` (cf-shims, server,
conformance-target), it breaks resolution of Node's own `Buffer`
overloads: any `buf.toString(encoding)` call across the workspace
resolves to the zero-arg `Object.prototype.toString` instead, since
verified with a minimal repro and by bisecting each of the 7 bumped
packages individually. This is present in every workers-types release
through 5.20260822.1, so it is not transient.

wrangler >=4.120.0 peer-depends on workers-types
`^5.20260811.1`, and vitest-pool-workers 0.21.3 pulls in that wrangler,
so the three are held back together to avoid an unmet-peer warning.
eslint, typescript-eslint, @types/node, and esbuild keep their bumps.

@davidwkeith davidwkeith left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against CONTRIBUTING.md. The dependency-bump logic and root-cause writeup for holding back @cloudflare/workers-types/wrangler/@cloudflare/vitest-pool-workers look sound. Two conformance issues worth fixing before merge (GitHub won't let me self-request-changes on this PR, so flagging as a comment instead):

  1. PR title scope (inline comment on package.json): chore(deps-dev): … uses a scope that isn't a package name. Per CONTRIBUTING.md §6, this repo-wide change should drop the scope entirely: chore: bump dev-dependencies group, hold back workers-types/wrangler. Since this repo squash-merges PRs, the title is what lands in git log — worth getting right.

  2. "Packages affected" section is inaccurate. It lists "Root package.json, @dwk/conformance-target, @dwk/server", but the diff doesn't touch packages/conformance-target/package.json at all, and it omits @dwk/cf-shims and @dwk/deno-host, both of which do have @types/node bumped in this PR. Please correct the list to: root package.json, @dwk/cf-shims, @dwk/deno-host, @dwk/server.

Minor: the changeset checkbox reason ("not applicable … no publishable package affected") is slightly misleading — @dwk/cf-shims and @dwk/deno-host are publishable packages; the real reason a changeset isn't needed is that dev-dependency bumps don't affect the published artifact/version. Worth tightening the wording so it doesn't read as a factual claim that's contradicted by the diff.

CI was still in progress (build-test, image, integration) at review time — please confirm all five local-gate equivalents are green before merging, per the checklist.


Generated by Claude Code

Comment thread package.json
@davidwkeith
davidwkeith enabled auto-merge (squash) August 22, 2026 18:12
@davidwkeith davidwkeith changed the title chore(deps-dev): bump dev-dependencies group, hold back workers-types/wrangler chore: bump dev-dependencies group, hold back workers-types/wrangler Aug 22, 2026
@davidwkeith
davidwkeith merged commit 3206362 into main Aug 22, 2026
9 checks passed
@davidwkeith
davidwkeith deleted the claude/pr-491-40648f branch August 22, 2026 18:28
@davidwkeith

Copy link
Copy Markdown
Owner Author

Addressed both review points:

  1. Title scope — fixed, now chore: bump dev-dependencies group, hold back workers-types/wrangler (replied inline and resolved that thread).
  2. "Packages affected" accuracy — corrected to root package.json, @dwk/cf-shims, @dwk/deno-host, @dwk/server; also tightened the changeset checkbox reason to note cf-shims/deno-host are publishable but a devDependency-only bump doesn't warrant a version bump.

All five CI checks are green (build-test, image, integration, release-gate, CodeQL), confirming the local gate result already noted in the PR description.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant