chore(deps-dev): bump the dev-dependencies group across 1 directory with 7 updates - #491
chore(deps-dev): bump the dev-dependencies group across 1 directory with 7 updates#491dependabot[bot] wants to merge 1 commit into
Conversation
|
Code review: this PR conforms to
at newUniqueId(): ShimDurableObjectId {
return new ShimDurableObjectId(randomBytes(32).toString("hex"));
}This bump includes Worth confirming against the Generated by Claude Code |
davidwkeith
left a comment
There was a problem hiding this comment.
CI is red — this bump breaks the build
build-test, integration, and image all fail with the same root cause:
packages/cf-shims/src/durable-object.ts(497,61): error TS2554: Expected 0 arguments, but got 1.
That's randomBytes(32).toString("hex") in newUniqueId() — a plain Node Buffer call, unrelated to this diff's content. I bisected it locally in an isolated worktree by reinstalling with each of the two @types/* bumps reverted individually:
- Reverting
@cloudflare/workers-typesalone (5.20260804.1, keeping@types/node@26.2.0) → typecheck passes. - Keeping
@cloudflare/workers-types@5.20260812.1→ typecheck fails.
So @cloudflare/workers-types@5.20260812.1 is the breaking dependency — something in that release changes global type resolution enough that Buffer#toString resolves to a zero-arg overload in packages/cf-shims (which sets "types": ["node", "@cloudflare/workers-types"]). This isn't a false-positive/flaky failure; it reproduces deterministically.
Note the two bumps aren't independently revertible as a quick fix: wrangler@4.122.0 (also bumped here) declares a peer dependency on @cloudflare/workers-types@^5.20260811.1, so simply pinning workers-types back conflicts with the wrangler bump in the same group. This needs an actual fix in @dwk/cf-shims (or an upstream issue against @cloudflare/workers-types) before this group can land — please don't merge as-is per CONTRIBUTING.md's CI gate ("All five must pass").
Minor — PR title convention
CONTRIBUTING.md asks for Conventional Commits titles where the scope is a package name, omitted entirely for repo-wide changes (chore: …), since this repo squash-merges and the PR title becomes the permanent log entry. deps-dev isn't a package scope — worth retitling before merge, e.g. chore: bump dev dependencies, since dependabot.yml has no commit-message override to produce a compliant title automatically.
Generated by Claude Code
e60f6b6 to
afba552
Compare
…ith 7 updates Bumps the dev-dependencies group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@cloudflare/vitest-pool-workers](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/vitest-pool-workers) | `0.20.2` | `0.21.3` | | [@cloudflare/workers-types](https://github.com/cloudflare/workerd) | `5.20260804.1` | `5.20260816.1` | | [eslint](https://github.com/eslint/eslint) | `10.8.0` | `10.8.1` | | [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.66.0` | `8.67.0` | | [wrangler](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler) | `4.119.0` | `4.123.0` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `26.1.2` | `26.2.0` | | [esbuild](https://github.com/evanw/esbuild) | `0.28.1` | `0.28.2` | Updates `@cloudflare/vitest-pool-workers` from 0.20.2 to 0.21.3 - [Release notes](https://github.com/cloudflare/workers-sdk/releases) - [Changelog](https://github.com/cloudflare/workers-sdk/blob/main/packages/vitest-pool-workers/CHANGELOG.md) - [Commits](https://github.com/cloudflare/workers-sdk/commits/@cloudflare/vitest-pool-workers@0.21.3/packages/vitest-pool-workers) Updates `@cloudflare/workers-types` from 5.20260804.1 to 5.20260816.1 - [Release notes](https://github.com/cloudflare/workerd/releases) - [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md) - [Commits](https://github.com/cloudflare/workerd/commits) Updates `eslint` from 10.8.0 to 10.8.1 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.8.0...v10.8.1) Updates `typescript-eslint` from 8.66.0 to 8.67.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.67.0/packages/typescript-eslint) Updates `wrangler` from 4.119.0 to 4.123.0 - [Release notes](https://github.com/cloudflare/workers-sdk/releases) - [Commits](https://github.com/cloudflare/workers-sdk/commits/wrangler@4.123.0/packages/wrangler) Updates `@types/node` from 26.1.2 to 26.2.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `esbuild` from 0.28.1 to 0.28.2 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.28.1...v0.28.2) --- updated-dependencies: - dependency-name: "@cloudflare/vitest-pool-workers" dependency-version: 0.21.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: "@cloudflare/workers-types" dependency-version: 5.20260812.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: "@types/node" dependency-version: 26.2.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: esbuild dependency-version: 0.28.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: eslint dependency-version: 10.8.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: typescript-eslint dependency-version: 8.67.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: wrangler dependency-version: 4.122.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
afba552 to
5421a9c
Compare
|
Superseded by #507, which carries the same dependency bump but holds back @cloudflare/workers-types (and the two packages coupled to it via peer deps, wrangler and @cloudflare/vitest-pool-workers) — that bump broke CI here because workers-types >=5.20260807.2 adds a global |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the dev-dependencies group with 7 updates in the / directory:
0.20.20.21.35.20260804.15.20260816.110.8.010.8.18.66.08.67.04.119.04.123.026.1.226.2.00.28.10.28.2Updates
@cloudflare/vitest-pool-workersfrom 0.20.2 to 0.21.3Release notes
Sourced from @cloudflare/vitest-pool-workers's releases.
... (truncated)
Changelog
Sourced from @cloudflare/vitest-pool-workers's changelog.
... (truncated)
Commits
c576a82Version Packages (#15154)e5d56e9Version Packages (#15145)d0c976cBump the workerd-and-workers-types group across 1 directory with 2 updates (#...90dd5e5chore: bump capnp-es to 0.0.15 (#15131)15fc568Version Packages (#15118)ab9132d[vitest-pool-workers] Report unavailable built-ins as module errors instead o...d2f377eVersion Packages (#15111)2194f88new config miniflare attempt 3 (#14994)b0aea76Version Packages (#15036)Updates
@cloudflare/workers-typesfrom 5.20260804.1 to 5.20260816.1Commits
Updates
eslintfrom 10.8.0 to 10.8.1Release notes
Sourced from eslint's releases.
Commits
c049dc310.8.1a3f7826Build: changelog update for 10.8.118eb0a7fix: prevent ASI hazard inno-unused-labelsautofix (#21173)0a14800chore: update github/codeql-action action to v4.37.4 (#21196)7d0cbf8docs: Update README05adcb1test: fix failing ecosystem test foreslint-plugin-unicorn(#21191)5611035test: add error locations info tono-void(#21185)ee47333ci: bump github/codeql-action from 4 to 4.37.3 (#21176)f131c03chore: improve ecosystem test failure reporting (#20937)0a05812docs: add missing backticks tono-duplicate-imports.js(#21183)Updates
typescript-eslintfrom 8.66.0 to 8.67.0Release notes
Sourced from typescript-eslint's releases.
Changelog
Sourced from typescript-eslint's changelog.
Commits
20a261fchore(release): publish 8.67.0c245fbbfeat(typescript-eslint): export basic globs for using tseslint (#12105)3b155bbchore: use typescript 7 for typechecking (#12601)Updates
wranglerfrom 4.119.0 to 4.123.0Release notes
Sourced from wrangler's releases.
... (truncated)
Commits
c576a82Version Packages (#15154)339509dAdd automatic update prompts for out-of-date Cloudflare agent skills (#14872)b8fd112feat: implement local dev for ctx.access (#15113)f0f2054Replace ignore-defaults with ignore-base-config CLI arg for Previews (#15152)e5d56e9Version Packages (#15145)3b02915[wrangler] Avoid stale remote binding sessions (#15142)d0c976cBump the workerd-and-workers-types group across 1 directory with 2 updates (#...15fc568Version Packages (#15118)5b1b930Fetch script metadata directly instead of listing all scripts (#15132)0aa8fa5SupportDO_NOT_TRACK=1(#14924)Updates
@types/nodefrom 26.1.2 to 26.2.0Commits
Updates
esbuildfrom 0.28.1 to 0.28.2Release notes
Sourced from esbuild's releases.
... (truncated)
Changelog
Sourced from esbuild's changelog.
... (truncated)
Commits
609683dpublish 0.28.2 to npm11b1fe4add to release notesab50d91css: fix green/blue channel swap in oklch gamut mapping (#4488)04627b6fix #4498:asyncTLA checks need a worklist5c15177disablegoplsin thegofolderfc2ee9bcss: adjust parser to allow--foo: {...}209db54release notes for css nesting bugfixc625d31fix #4497: preserve nested ampersands during minification (#4500)34474e2better isolation of current part in js parser07f6e8cfix #4507:importassignment tree-shaking bug