-
Notifications
You must be signed in to change notification settings - Fork 124
Added a workflow to parallelise the E2E tests. Updated E2E tests to c… #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msrathore-db
wants to merge
24
commits into
main
Choose a base branch
from
testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
61af772
Added a workflow to parallelise the E2E tests. Updated E2E tests to c…
msrathore-db 1417f6b
Modified parallel code coverage workflow to fail when e2e tests fail
msrathore-db bf24771
Fixed parallel coverage check pytest command
msrathore-db 4bbc653
Modified e2e tests to support parallel execution
msrathore-db 7ef1033
Added fallbacks for exit code 5 where we find no test for SEA
msrathore-db d21f214
Fixed coverage artifact for parallel test workflow
msrathore-db 9cb8999
Debugging coverage check merge
msrathore-db 59e83ab
Improved coverage report merge and removed the test_driver test for f…
msrathore-db 271ecac
Debug commit for coverage merge
msrathore-db b6ac8cb
Debugging coverage merge 2
msrathore-db 1c2f238
Debugging coverage merge 3
msrathore-db 3657fbd
Removed unnecessary debug statements from the parallel code coverage …
msrathore-db 2b4e257
Added unit test and common e2e tests
msrathore-db 19407ab
Added null checks for coverage workflow
msrathore-db 6df96be
Improved the null check for test list
msrathore-db 602809b
Improved the visibility for test list
msrathore-db b25ed87
Added check for exit code 5
msrathore-db b5b6cfb
main changes
msrathore-db 45ef85a
Updated the workflowfor coverage check to use pytst -xdist to run the…
msrathore-db 0e1033a
Enforced the e2e tests should pass
msrathore-db dac7c55
Changed name for workflow job
msrathore-db bf0a245
Updated poetry
msrathore-db 39316f8
Removed integration and previous code coverage workflow
msrathore-db 3ac2445
Added the integration workflow again
msrathore-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,136 @@ | ||
name: Code Coverage | ||
|
||
permissions: | ||
contents: read | ||
|
||
on: [pull_request, workflow_dispatch] | ||
|
||
jobs: | ||
test-with-coverage: | ||
runs-on: ubuntu-latest | ||
environment: azure-prod | ||
env: | ||
DATABRICKS_SERVER_HOSTNAME: ${{ secrets.DATABRICKS_HOST }} | ||
DATABRICKS_HTTP_PATH: ${{ secrets.TEST_PECO_WAREHOUSE_HTTP_PATH }} | ||
DATABRICKS_TOKEN: ${{ secrets.DATABRICKS_TOKEN }} | ||
DATABRICKS_CATALOG: peco | ||
DATABRICKS_USER: ${{ secrets.TEST_PECO_SP_ID }} | ||
steps: | ||
#---------------------------------------------- | ||
# check-out repo and set-up python | ||
#---------------------------------------------- | ||
- name: Check out repository | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
ref: ${{ github.event.pull_request.head.ref || github.ref_name }} | ||
repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }} | ||
- name: Set up python | ||
id: setup-python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.10" | ||
#---------------------------------------------- | ||
# ----- install & configure poetry ----- | ||
#---------------------------------------------- | ||
- name: Install Poetry | ||
uses: snok/install-poetry@v1 | ||
with: | ||
virtualenvs-create: true | ||
virtualenvs-in-project: true | ||
installer-parallel: true | ||
|
||
#---------------------------------------------- | ||
# load cached venv if cache exists | ||
#---------------------------------------------- | ||
- name: Load cached venv | ||
id: cached-poetry-dependencies | ||
uses: actions/cache@v4 | ||
with: | ||
path: .venv | ||
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }} | ||
#---------------------------------------------- | ||
# install dependencies if cache does not exist | ||
#---------------------------------------------- | ||
- name: Install dependencies | ||
if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true' | ||
run: poetry install --no-interaction --no-root | ||
#---------------------------------------------- | ||
# install your root project, if required | ||
#---------------------------------------------- | ||
- name: Install library | ||
run: poetry install --no-interaction --all-extras | ||
#---------------------------------------------- | ||
# run all tests with coverage | ||
#---------------------------------------------- | ||
- name: Run all tests with coverage | ||
continue-on-error: false | ||
run: | | ||
poetry run pytest tests/unit tests/e2e \ | ||
-n auto \ | ||
--cov=src \ | ||
--cov-report=xml \ | ||
--cov-report=term \ | ||
-v | ||
|
||
#---------------------------------------------- | ||
# check for coverage override | ||
#---------------------------------------------- | ||
- name: Check for coverage override | ||
id: override | ||
run: | | ||
OVERRIDE_COMMENT=$(echo "${{ github.event.pull_request.body }}" | grep -E "SKIP_COVERAGE_CHECK\s*=" || echo "") | ||
if [ -n "$OVERRIDE_COMMENT" ]; then | ||
echo "override=true" >> $GITHUB_OUTPUT | ||
REASON=$(echo "$OVERRIDE_COMMENT" | sed -E 's/.*SKIP_COVERAGE_CHECK\s*=\s*(.+)/\1/') | ||
echo "reason=$REASON" >> $GITHUB_OUTPUT | ||
echo "Coverage override found in PR description: $REASON" | ||
else | ||
echo "override=false" >> $GITHUB_OUTPUT | ||
echo "No coverage override found" | ||
fi | ||
#---------------------------------------------- | ||
# check coverage percentage | ||
#---------------------------------------------- | ||
- name: Check coverage percentage | ||
if: steps.override.outputs.override == 'false' | ||
run: | | ||
COVERAGE_FILE="coverage.xml" | ||
if [ ! -f "$COVERAGE_FILE" ]; then | ||
echo "ERROR: Coverage file not found at $COVERAGE_FILE" | ||
exit 1 | ||
fi | ||
|
||
# Install xmllint if not available | ||
if ! command -v xmllint &> /dev/null; then | ||
sudo apt-get update && sudo apt-get install -y libxml2-utils | ||
fi | ||
|
||
COVERED=$(xmllint --xpath "string(//coverage/@lines-covered)" "$COVERAGE_FILE") | ||
TOTAL=$(xmllint --xpath "string(//coverage/@lines-valid)" "$COVERAGE_FILE") | ||
PERCENTAGE=$(python3 -c "covered=${COVERED}; total=${TOTAL}; print(round((covered/total)*100, 2))") | ||
|
||
echo "Branch Coverage: $PERCENTAGE%" | ||
echo "Required Coverage: 85%" | ||
|
||
# Use Python to compare the coverage with 85 | ||
python3 -c "import sys; sys.exit(0 if float('$PERCENTAGE') >= 85 else 1)" | ||
if [ $? -eq 1 ]; then | ||
echo "ERROR: Coverage is $PERCENTAGE%, which is less than the required 85%" | ||
exit 1 | ||
else | ||
echo "SUCCESS: Coverage is $PERCENTAGE%, which meets the required 85%" | ||
fi | ||
|
||
#---------------------------------------------- | ||
# coverage enforcement summary | ||
#---------------------------------------------- | ||
- name: Coverage enforcement summary | ||
run: | | ||
if [ "${{ steps.override.outputs.override }}" == "true" ]; then | ||
echo "⚠️ Coverage checks bypassed: ${{ steps.override.outputs.reason }}" | ||
echo "Please ensure this override is justified and temporary" | ||
else | ||
echo "✅ Coverage checks enforced - minimum 85% required" | ||
fi | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is satisfying the usecase, why have you not deleted this file -.github/workflows/coverage-check.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove both coverage-check and integrations workflow since the new workflow satisfies the needs. Just kept the workflow to ensure the coverage percentage is same for the new workflow as well.