Added a workflow to parallelise the E2E tests. Updated E2E tests to c… #697

msrathore-db · 2025-10-03T07:53:34Z

What type of PR is this?

Refactor
Feature
Bug Fix
Other

Description

Added a workflow to parallelise the E2E tests. Updated E2E tests to create new table names for each run to avoid issue in parallelisation

How is this tested?

Unit tests
E2E Tests
Manually
N/A

Related Tickets & Documents

…reate new table names for each run to avoid issue in parallelisation

github-actions · 2025-10-03T07:53:44Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

github-actions · 2025-10-03T08:04:25Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

jprakash-db · 2025-10-07T11:51:41Z

.github/workflows/coverage-check-parallel.yml

+          key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
+
+      - name: Install dependencies
+        if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true'
+        run: poetry install --no-interaction --no-root
+
+      - name: Install library
+        run: poetry install --no-interaction --all-extras
+


why is the poetry setup part being done multiple times, each part basically has the same setup

jprakash-db · 2025-10-07T11:53:06Z

.github/workflows/coverage-check-parallel.yml

+
+      - name: Set up python
+        id: setup-python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.10"
+
+      - name: Install Poetry
+        uses: snok/install-poetry@v1
+        with:
+          virtualenvs-create: true
+          virtualenvs-in-project: true
+          installer-parallel: true
+
+      - name: Load cached venv
+        id: cached-poetry-dependencies
+        uses: actions/cache@v4
+        with:
+          path: .venv
+          key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}


Again we are creating multiple environments , which is just too much overhead.
Simpler would be create a first job called setup that installs the poetry and activates the venv
Then find all the test files and execute them in matrix fashion within the setup done first
Don't think it is efficient to create the entire venv setup for each test

jprakash-db · 2025-10-07T11:59:03Z

.github/workflows/coverage-check-parallel.yml

+    if: ${{ needs.discover-tests.outputs.common-test-files != '[]' }}
+    strategy:
+      matrix:
+        test_file: ${{ fromJson(needs.discover-tests.outputs.common-test-files) }}


why are you running each single test is parallel. This is just too much overhead. When using a matrix you are basically spinning up a VM for each test and this is just wrong

jprakash-db · 2025-10-07T12:05:21Z

The current setup has a lot of boiler plate and is just not efficient
Problems in the current stup

You are spinning up a new VM for each single test which is just too much overhead
There is just too much code duplication, in each tests a bulk of the code is just installing the library

My suggestion is to have jobs that are concentrated

First job just installs the poetry and stores in a cache
Second job finds all the tests and segregates it into the unit-test, e2e-test, etc
Now start executing the tests, now since step1 is done you know we have a cache hit, to just install from there
Execute bulk operations in parallel, like unit- test on 1 vm, e2e-test on 1 vm ,etc. Don't make VM per test
If you want faster execution explore something like pytest -xdist that runs tests in parallel on a single VM

jprakash-db · 2025-10-07T12:06:12Z

I can see the tests still took 1 hr to run, so what exactly is the optimisation?

Code Coverage / coverage (pull_request)
Code Coverage / coverage (pull_request)Successful in 57m

… tests parallely

github-actions · 2025-10-09T09:55:35Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

github-actions · 2025-10-09T09:57:24Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

github-actions · 2025-10-09T10:02:10Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

jprakash-db · 2025-10-13T17:30:58Z

tests/e2e/test_parameterized_queries.py

+        table_name = self.inline_table_name
+        INSERT_QUERY = f"INSERT INTO {table_name} (`{target_column}`) VALUES (%(p)s)"
+        SELECT_QUERY = f"SELECT {target_column} `col` FROM {table_name} LIMIT 1"
+        DELETE_QUERY = f"DELETE FROM {table_name}"


There is a incomplete resource cleanup here. If the Insert or Select query fails then the Delete query will never be executed and so for every new run we will end up creating new garbage tables

jprakash-db · 2025-10-13T17:35:52Z

.github/workflows/code-coverage.yml

@@ -0,0 +1,136 @@
+name: Code Coverage
+


If this is satisfying the usecase, why have you not deleted this file -.github/workflows/coverage-check.yml

Will remove both coverage-check and integrations workflow since the new workflow satisfies the needs. Just kept the workflow to ensure the coverage percentage is same for the new workflow as well.

jprakash-db · 2025-10-13T17:37:46Z

@msrathore-db If you have modified the code such that tests can be run in parallel, why don't you updated the integration.yml test running also to use pytest xdist. So that integration test can also run faster

jprakash-db · 2025-10-13T17:42:33Z

I can see some random residual tables? Are these from testing setups?

msrathore-db · 2025-10-13T21:30:24Z

@msrathore-db If you have modified the code such that tests can be run in parallel, why don't you updated the integration.yml test running also to use pytest xdist. So that integration test can also run faster

Would be removing the workflow to avoid running e2e tests twice.

github-actions · 2025-10-14T12:18:07Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

github-actions · 2025-10-14T12:38:15Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Added a workflow to parallelise the E2E tests. Updated E2E tests to c…

61af772

…reate new table names for each run to avoid issue in parallelisation

msrathore-db temporarily deployed to azure-prod October 3, 2025 07:53 — with GitHub Actions Inactive

msrathore-db had a problem deploying to azure-prod October 3, 2025 07:53 — with GitHub Actions Failure

msrathore-db temporarily deployed to azure-prod October 3, 2025 07:53 — with GitHub Actions Inactive

msrathore-db added 2 commits October 3, 2025 13:25

Modified parallel code coverage workflow to fail when e2e tests fail

1417f6b

Fixed parallel coverage check pytest command

bf24771

msrathore-db temporarily deployed to azure-prod October 3, 2025 08:04 — with GitHub Actions Inactive

msrathore-db had a problem deploying to azure-prod October 3, 2025 08:04 — with GitHub Actions Failure

msrathore-db had a problem deploying to azure-prod October 3, 2025 08:04 — with GitHub Actions Error

msrathore-db had a problem deploying to azure-prod October 3, 2025 08:04 — with GitHub Actions Failure

msrathore-db had a problem deploying to azure-prod October 3, 2025 08:04 — with GitHub Actions Error

Modified e2e tests to support parallel execution

4bbc653

jprakash-db reviewed Oct 7, 2025

View reviewed changes

Updated the workflowfor coverage check to use pytst -xdist to run the…

45ef85a

… tests parallely

msrathore-db had a problem deploying to azure-prod October 9, 2025 09:55 — with GitHub Actions Failure

msrathore-db added 2 commits October 9, 2025 15:26

Enforced the e2e tests should pass

0e1033a

Changed name for workflow job

dac7c55

msrathore-db had a problem deploying to azure-prod October 9, 2025 09:57 — with GitHub Actions Failure

Updated poetry

bf0a245

msrathore-db temporarily deployed to azure-prod October 9, 2025 10:02 — with GitHub Actions Inactive

msrathore-db had a problem deploying to azure-prod October 9, 2025 10:02 — with GitHub Actions Error

msrathore-db temporarily deployed to azure-prod October 9, 2025 10:02 — with GitHub Actions Inactive

jprakash-db reviewed Oct 13, 2025

View reviewed changes

Removed integration and previous code coverage workflow

39316f8

msrathore-db temporarily deployed to azure-prod October 14, 2025 12:18 — with GitHub Actions Inactive

Added the integration workflow again

3ac2445

msrathore-db temporarily deployed to azure-prod October 14, 2025 12:38 — with GitHub Actions Inactive

Added a workflow to parallelise the E2E tests. Updated E2E tests to c… #697

Are you sure you want to change the base?

Added a workflow to parallelise the E2E tests. Updated E2E tests to c… #697

Uh oh!

Conversation

msrathore-db commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

Description

How is this tested?

Related Tickets & Documents

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

jprakash-db Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jprakash-db Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jprakash-db Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jprakash-db commented Oct 7, 2025

Uh oh!

jprakash-db commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

jprakash-db Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

jprakash-db Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

msrathore-db Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

jprakash-db commented Oct 13, 2025

Uh oh!

jprakash-db commented Oct 13, 2025

Uh oh!

msrathore-db commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

msrathore-db commented Oct 3, 2025 •

edited

Loading

jprakash-db commented Oct 7, 2025 •

edited

Loading