Skip to content

Make validation steps optional to fix appkit caching breaking npm ins… #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igrekun merged 2 commits into from
Jan 15, 2026
Merged

Make validation steps optional to fix appkit caching breaking npm ins… #4290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b3b347
Make validation steps optional to fix appkit caching breaking npm ins…
igrekun Jan 15, 2026
39efa86
Merge branch 'main' into igor/nodejs-optional-validation
igrekun Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions experimental/aitools/lib/validation/nodejs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ type validationStep struct {
command string
errorPrefix string
displayName string
optional bool
}

func (v *ValidationNodeJs) Validate(ctx context.Context, workDir string) (*ValidateResult, error) {
Expand All @@ -31,12 +32,14 @@ func (v *ValidationNodeJs) Validate(ctx context.Context, workDir string) (*Valid
command: "npm install",
errorPrefix: "Failed to install dependencies",
displayName: "Install",
optional: true,
},
{
name: "generate",
command: "npm run typegen --if-present",
errorPrefix: "Failed to run npm typegen",
displayName: "Type generation",
optional: true,
},
{
name: "build",
Expand All @@ -55,6 +58,7 @@ func (v *ValidationNodeJs) Validate(ctx context.Context, workDir string) (*Valid
command: "npm run lint:ast-grep --if-present",
errorPrefix: "AST-grep lint found violations",
displayName: "AST-grep lint",
optional: true,
},
{
name: "tests",
Expand All @@ -73,6 +77,11 @@ func (v *ValidationNodeJs) Validate(ctx context.Context, workDir string) (*Valid
err := runCommand(ctx, workDir, step.command)
if err != nil {
stepDuration := time.Since(stepStart)
if step.optional {
log.Debugf(ctx, "%s failed (optional, duration: %.1fs)", step.name, stepDuration.Seconds())
progressLog = append(progressLog, fmt.Sprintf("⏭️ %s skipped (%.1fs)", step.displayName, stepDuration.Seconds()))
continue
}
log.Errorf(ctx, "%s failed (duration: %.1fs)", step.name, stepDuration.Seconds())
progressLog = append(progressLog, fmt.Sprintf("❌ %s failed (%.1fs)", step.displayName, stepDuration.Seconds()))
return &ValidateResult{
Expand Down