-
Notifications
You must be signed in to change notification settings - Fork 131
Make validation steps optional to fix appkit caching breaking npm ins… #4290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keugenek
approved these changes
Jan 15, 2026
arsenyinfo
approved these changes
Jan 15, 2026
Collaborator
|
Commit: 9b3b347
22 interesting tests: 10 KNOWN, 8 RECOVERED, 3 flaky, 1 SKIP
Top 49 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: b2e18d8
25 interesting tests: 10 KNOWN, 8 RECOVERED, 6 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make nodejs validation steps optional enabling agents to work with the template.
Why
Currently type generation in appkit breaks npm cache making any subsequent npm install commands fail.
Tests