Give error if global activated package depends on hooks #4612
Conversation
sigurdm
force-pushed
the
global_error_on_hooks2
branch
from
9aa919e to
30eb18c
Compare
|
@dcharkes The error message here is quite imprecise and unhelpful. Do we want to give details (which dependency is using hooks?) Do we want to point the user to some documentation? |
|
Thanks @sigurdm! 🙏
If it's easy, we can name the package that's using hooks.
We should add some info that we're not intending to support hooks in |
sigurdm
changed the title
|
@dcharkes If you are happy could you approve? |
| () async { | ||
| final server = await servePackages(); | ||
| server.serve( | ||
| 'hooks', |
There was a problem hiding this comment.
Please use a different name for this, as this https://pub.dev/packages/hooks/versions/0.19.5 should never contain a hook.
| }, | ||
| ); | ||
|
|
||
| test('activating a hosted package gives error if package uses hooks in any' |
There was a problem hiding this comment.
Test name needs to be updated. A hook in a dev dep is fine.
Fixes #4609
More refactoring could be used here. But this seems good enough for now.