Give error if globall activated package depends on hooks

Author: sigurdm

lib/src/global_packages.dart

@@ -192,6 +192,12 @@ class GlobalPackages {
 
     // Get the package's dependencies.
     await entrypoint.acquireDependencies(SolveType.get);
+    for (final package in (await entrypoint.packageGraph)
+        .transitiveDependencies(entrypoint.workPackage.name)) {
+      if (fileExists(p.join(package.dir, 'hooks', 'build.dart'))) {
+        fail('Cannot `global activate` packages with hooks.');
+      }
+    }
     final activatedPackage = entrypoint.workPackage;
     final name = activatedPackage.name;
     _describeActive(name, cache);
@@ -260,10 +266,24 @@ class GlobalPackages {
       }
       rethrow;
     }
+
     // We want the entrypoint to be rooted at 'dep' not the dummy-package.
     result.packages.removeWhere((id) => id.name == 'pub global activate');
 
     final lockFile = await result.downloadCachedPackages(cache);
+
+    // Because we know that the dummy package never is a workspace we can
+    // iterate all packages.
+    // TODO(sigurdm): refactor PackageGraph to make it possible to query without
+    // loading entrypoint.
+    for (final package in result.packages) {
+      if (fileExists(
+        p.join(cache.getDirectory(package), 'hooks', 'build.dart'),
+      )) {
+        fail('Cannot `global activate` packages with hooks.');
+      }
+    }
+
     final sameVersions =
         originalLockFile != null && originalLockFile.samePackageIds(lockFile);
 

lib/src/package_graph.dart

@@ -2,14 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:graphs/graphs.dart';
-
 import 'entrypoint.dart';
 import 'package.dart';
 import 'solver.dart';
 import 'source/cached.dart';
 import 'source/sdk.dart';
-import 'utils.dart';
 
 /// A holistic view of the entire transitive dependency graph for an entrypoint.
 class PackageGraph {
@@ -23,9 +20,6 @@ class PackageGraph {
   /// relevant in the current context.
   final Map<String, Package> packages;
 
-  /// A map of transitive dependencies for each package.
-  Map<String, Set<Package>>? _transitiveDependencies;
-
   PackageGraph(this.entrypoint, this.packages);
 
   /// Creates a package graph using the data from [result].
@@ -56,27 +50,21 @@ class PackageGraph {
   /// dev and override. For any other package, it ignores dev and override
   /// dependencies.
   Set<Package> transitiveDependencies(String package) {
-    if (package == entrypoint.workspaceRoot.name) {
-      return packages.values.toSet();
-    }
+    final result = <Package>{};
 
-    if (_transitiveDependencies == null) {
-      final graph = mapMap<String, Package, String, Iterable<String>>(
-        packages,
-        value: (_, package) => package.dependencies.keys,
-      );
-      final closure = transitiveClosure(graph.keys, (n) => graph[n]!);
-      _transitiveDependencies =
-          mapMap<String, Set<String>, String, Set<Package>>(
-            closure,
-            value: (depender, names) {
-              final set = names.map((name) => packages[name]!).toSet();
-              set.add(packages[depender]!);
-              return set;
-            },
-          );
+    final stack = [package];
+    final visited = <String>{};
+    while (stack.isNotEmpty) {
+      final current = stack.removeLast();
+      if (!visited.add(current)) continue;
+      final currentPackage = packages[current]!;
+      result.add(currentPackage);
+      stack.addAll(currentPackage.dependencies.keys);
+      if (current == package) {
+        stack.addAll(currentPackage.devDependencies.keys);
+      }
     }
-    return _transitiveDependencies![package]!;
+    return result;
   }
 
   bool _isPackageFromImmutableSource(String package) {

pubspec.lock

@@ -474,4 +474,4 @@ packages:
     source: hosted
     version: "2.2.2"
 sdks:
-  dart: ">=3.7.0 <4.0.0"
+  dart: ">=3.8.0 <4.0.0"

test/global/activate/activate_package_with_hooks_test.dart

@@ -0,0 +1,106 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:path/path.dart' as p;
+import 'package:test/test.dart';
+
+import '../../descriptor.dart';
+import '../../test_pub.dart';
+
+void main() {
+  test(
+    'activating a package from path gives error if package uses hooks',
+    () async {
+      final server = await servePackages();
+      server.serve(
+        'hooks',
+        '1.0.0',
+        contents: [
+          dir('hooks', [file('build.dart')]),
+        ],
+      );
+      server.serve('no_hooks', '1.0.0');
+
+      await dir(appPath, [
+        libPubspec(
+          'foo',
+          '1.2.3',
+          extras: {
+            'workspace': ['pkgs/foo_hooks', 'pkgs/foo_no_hooks'],
+          },
+          sdk: '^3.5.0',
+        ),
+        dir('pkgs', [
+          dir('foo_hooks', [
+            libPubspec(
+              'foo_hooks',
+              '1.1.1',
+              devDeps: {'hooks': '^1.0.0'},
+              resolutionWorkspace: true,
+            ),
+          ]),
+          dir('foo_no_hooks', [
+            libPubspec(
+              'foo_no_hooks',
+              '1.1.1',
+              deps: {'no_hooks': '^1.0.0'},
+              resolutionWorkspace: true,
+            ),
+          ]),
+        ]),
+      ]).create();
+
+      await runPub(
+        args: ['global', 'activate', '-spath', p.join('pkgs', 'foo_hooks')],
+        environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+        error: 'Cannot `global activate` packages with hooks.',
+        exitCode: 1,
+      );
+
+      await runPub(
+        args: ['global', 'activate', '-spath', p.join('pkgs', 'foo_no_hooks')],
+        environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+      );
+    },
+  );
+
+  test('activating a hosted package gives error if package uses hooks in any'
+      ' dependency', () async {
+    final server = await servePackages();
+    server.serve(
+      'hooks',
+      '1.0.0',
+      contents: [
+        dir('hooks', [file('build.dart')]),
+      ],
+    );
+    server.serve('foo_hooks', '1.1.1', deps: {'hooks': '^1.0.0'});
+    server.serve(
+      'foo_hooks_in_dev_deps',
+      '1.0.0',
+      pubspec: {
+        'dev_dependencies': {'hooks': '^1.0.0'},
+      },
+    );
+
+    await runPub(
+      args: ['global', 'activate', 'hooks'],
+      environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+      error: 'Cannot `global activate` packages with hooks.',
+      exitCode: 1,
+    );
+
+    await runPub(
+      args: ['global', 'activate', 'foo_hooks'],
+      environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+      error: 'Cannot `global activate` packages with hooks.',
+      exitCode: 1,
+    );
+
+    await runPub(
+      args: ['global', 'activate', 'foo_hooks_in_dev_deps'],
+      environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
+    );
+  });
+}