Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin google-protobuf to non-buggy version #640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@types/node-fetch": "^2.6.2",
"body-parser": "^1.19.0",
"express": "^4.18.2",
"google-protobuf": "^3.18.0",
"google-protobuf": "^3.18.0 <3.21.4",
"http-terminator": "^3.2.0",
"node-fetch": "^2.6.7"
},
Expand Down
24 changes: 24 additions & 0 deletions test/components/secret-file.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#
# Copyright 2022 The Dapr Authors
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# http://www.apache.org/licenses/LICENSE-2.0
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
name: secret-file
namespace: default
spec:
type: secretstores.local.file
version: v1
metadata:
- name: secretsFile
value: test/components/secrets.json
3 changes: 3 additions & 0 deletions test/components/secrets.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"TEST_SECRET_1": "secret_value_1"
}
5 changes: 5 additions & 0 deletions test/e2e/grpc/client.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,11 @@ describe("grpc/client", () => {
const res = await client.secret.getBulk("secret-envvars");
expect(Object.keys(res).length).toBeGreaterThan(1);
});

it("should be able to correctly fetch the secrets in bulk from a file", async () => {
const res = await client.secret.getBulk("secret-file");
expect(Object.keys(res).length).toBeGreaterThan(0);
});
});

describe("crypto", () => {
Expand Down
Loading