Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin google-protobuf to non-buggy version #640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tlund101
Copy link
Contributor

@tlund101 tlund101 commented Oct 10, 2024

Description

[email protected] introduces a bug that results in secrets (and possibly other data) coming back as undefined via GRPC. This PR is a demo that adds an E2E test case and pins the google-protobuf version to a working version.

If you want to see the test fail, just unpin the library version and rebuild the lock file. I was not able to narrow down where in the protobuf library the issue is due to build issues, but I created issues in this repo as a stopgap and FYI. I figured a maintainer here may have a better insight as to where the problem lay.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 9, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants