-
Notifications
You must be signed in to change notification settings - Fork 221
Adding examples to Spring Boot (duration, zoneddatetime and suspend/resume) #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
58fffef
to
4fd0a74
Compare
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
4fd0a74
to
8f93b57
Compare
@dapr/maintainers-java-sdk what is missing for this to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice patch, thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
============================================
+ Coverage 76.91% 78.36% +1.44%
- Complexity 1592 1877 +285
============================================
Files 145 234 +89
Lines 4843 5832 +989
Branches 562 601 +39
============================================
+ Hits 3725 4570 +845
- Misses 821 941 +120
- Partials 297 321 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Adding examples to validate that ZonedDateTime works
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1409
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: