Skip to content

Pull out createTimer logic #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

Pull out createTimer logic #1419

merged 3 commits into from
Jun 11, 2025

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Jun 11, 2025

Pull out logic from this PR to add it to the release quicker. Examples should still be added in the original PR, but the logic should be rebased since it will go thru in this PR

@cicoyle cicoyle requested review from a team as code owners June 11, 2025 19:00
cicoyle added 2 commits June 11, 2025 14:01
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cicoyle cicoyle added this to the v1.15 milestone Jun 11, 2025
@cicoyle cicoyle merged commit e3fc48d into dapr:master Jun 11, 2025
10 of 12 checks passed
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (d759c53) to head (cbfbbbf).
Report is 169 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1419      +/-   ##
============================================
+ Coverage     76.91%   78.46%   +1.54%     
- Complexity     1592     1867     +275     
============================================
  Files           145      230      +85     
  Lines          4843     5790     +947     
  Branches        562      601      +39     
============================================
+ Hits           3725     4543     +818     
- Misses          821      927     +106     
- Partials        297      320      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants