Add retry handler support #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mason <[email protected]>
Signed-off-by: Mason <[email protected]>
Signed-off-by: Mason <[email protected]>
Signed-off-by: Mason <[email protected]>
Signed-off-by: Mason <[email protected]>
siri-varma
reviewed
Jun 10, 2025
sdk-workflows/src/main/java/io/dapr/workflows/WorkflowTaskFailureDetails.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mason <[email protected]>
Signed-off-by: Mason <[email protected]>
siri-varma
reviewed
Jun 10, 2025
sdk-workflows/src/test/java/io/dapr/workflows/DefaultWorkflowContextTest.java
Show resolved
Hide resolved
Signed-off-by: Mason <[email protected]>
|
checks failed because the durable task pr still needs to be merged, leading to the builds failing |
sdk-workflows/src/main/java/io/dapr/workflows/runtime/DefaultWorkflowContext.java
Outdated
Show resolved
Hide resolved
|
I think we should be good to try rerunning the workflows. Seems like it has published https://repo.maven.apache.org/maven2/io/dapr/durabletask-client/1.5.6/ |
|
Not sure if this failure is due to my changes. Can someone else take a look |
|
lets see with this next run if it was just flaky or a result of this PR 👍🏻 |
|
Passed on rerun. Thanks! |
|
@siri-varma @javier-aliaga Anything else that needs to be addressed here? |
cicoyle
approved these changes
Jun 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
============================================
+ Coverage 76.91% 78.46% +1.54%
- Complexity 1592 1867 +275
============================================
Files 145 230 +85
Lines 4843 5790 +947
Branches 562 601 +39
============================================
+ Hits 3725 4543 +818
- Misses 821 927 +106
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cicoyle
added a commit
to cicoyle/java-sdk
that referenced
this pull request
Jun 11, 2025
* Add retry handler support Signed-off-by: Mason <[email protected]> * Wrap DurableTask objects Signed-off-by: Mason <[email protected]> * Rename method Signed-off-by: Mason <[email protected]> * Add isNonRetriable field to WorkflowTaskFailureDetails Signed-off-by: Mason <[email protected]> * Add unit test Signed-off-by: Mason <[email protected]> * Removed duplicate WorkflowFailureDetails class Signed-off-by: Mason <[email protected]> * Removed unneeded when statements in retry policy unit test Signed-off-by: Mason <[email protected]> * Add unit test to test both RetryPolicy and RetryHandler Signed-off-by: Mason <[email protected]> * Create toRetryPolicy method Signed-off-by: Mason <[email protected]> --------- Signed-off-by: Mason <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: Cassie Coyle <[email protected]>
cicoyle
added a commit
that referenced
this pull request
Jun 11, 2025
* Add retry handler support * Wrap DurableTask objects * Rename method * Add isNonRetriable field to WorkflowTaskFailureDetails * Add unit test * Removed duplicate WorkflowFailureDetails class * Removed unneeded when statements in retry policy unit test * Add unit test to test both RetryPolicy and RetryHandler * Create toRetryPolicy method --------- Signed-off-by: Mason <[email protected]> Co-authored-by: Mason <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows users to use the RetryHandler class from DurableTask for retrying tasks. RetryHandler allows for a lot more customization than the RetryPolicy class does
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1406
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
This PR is dependent upon this durabletask pr dapr/durabletask-java#25