Skip to content

[1.15] Cherrypick wf retry handler #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Jun 11, 2025

* Add retry handler support

Signed-off-by: Mason <[email protected]>

* Wrap DurableTask objects

Signed-off-by: Mason <[email protected]>

* Rename method

Signed-off-by: Mason <[email protected]>

* Add isNonRetriable field to WorkflowTaskFailureDetails

Signed-off-by: Mason <[email protected]>

* Add unit test

Signed-off-by: Mason <[email protected]>

* Removed duplicate WorkflowFailureDetails class

Signed-off-by: Mason <[email protected]>

* Removed unneeded when statements in retry policy unit test

Signed-off-by: Mason <[email protected]>

* Add unit test to test both RetryPolicy and RetryHandler

Signed-off-by: Mason <[email protected]>

* Create toRetryPolicy method

Signed-off-by: Mason <[email protected]>

---------

Signed-off-by: Mason <[email protected]>
Co-authored-by: Siri Varma Vegiraju <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
@cicoyle cicoyle requested review from a team as code owners June 11, 2025 18:33
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cicoyle cicoyle merged commit b3ba75d into dapr:release-1.15 Jun 11, 2025
11 of 12 checks passed
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-1.15@e297d01). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...va/io/dapr/workflows/WorkflowTaskRetryContext.java 60.00% 4 Missing ⚠️
.../dapr/workflows/client/WorkflowFailureDetails.java 0.00% 1 Missing ⚠️
...rkflows/runtime/DefaultWorkflowFailureDetails.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.15    #1418   +/-   ##
===============================================
  Coverage                ?   77.60%           
  Complexity              ?     1788           
===============================================
  Files                   ?      207           
  Lines                   ?     5519           
  Branches                ?      600           
===============================================
  Hits                    ?     4283           
  Misses                  ?      916           
  Partials                ?      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants