Repository navigation
validate: stream missing annexed content with datalad-fuse - #1956
Draft
CodyCBakerPhD wants to merge 9 commits into
Draft
CodyCBakerPhD wants to merge 9 commits into
CodyCBakerPhD wants to merge 9 commits into
Conversation
Add a `stream` policy to `--missing-file-content`: the content of annexed files that is not present locally (as in a DataLad clone of a Dandiset) is streamed with datalad-fuse's adapter, so that pynwb and nwbinspector run on it without it being downloaded. pynwb validation results are cached under the files' git-annex keys. This is the validation integration of #1933, on top of the datalad-fuse readable rather than a git-only reader of the git-annex branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## claude/datalad-fuse-readable #1956 +/- ##
================================================================
+ Coverage 90.86% 90.93% +0.07%
================================================================
Files 94 94
Lines 14381 14520 +139
================================================================
+ Hits 13067 13204 +137
- Misses 1314 1316 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…am-via-datalad-fuse Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…am-via-datalad-fuse
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…am-via-datalad-fuse Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…am-via-datalad-fuse Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
This reverts commit d18843d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…to claude/validate-stream-via-datalad-fuse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1955. This is an alternative to #1933: the same validate integration, built on the datalad-fuse readable from #1955 instead of the git-only reader.
Changes
streampolicy for--missing-file-content:AnnexedReadableFile(datalad-fuse, no FUSE mount).DANDI.FILE_CONTENT_STREAMED, naming the first URL git-annex reported for its content.DANDI.FILE_CONTENT_MISSINGerror.dandi validateto operate on Datalad datasets through streaming #1933:LocalFileAsset.content_sourcelets an asset read its content from aReadable.pynwb_utils.validate(..., readable=...)validates content from aReadable; its results are cached under the annex key viaannex_fingerprintfrom Read missing annexed content with datalad-fuse, cached by annex key #1955.only-non-data.pip install "dandi[datalad]") and git-annex, and raises an error if either is missing.validatedocs explains the policy, usingdatalad clone.dandi validateto operate on Datalad datasets through streaming #1933 are rewritten to use a real git-annex repository and the local HTTP range server from Read missing annexed content with datalad-fuse, cached by annex key #1955. They cover:Compared to #1941 + #1933
905 added lines against the current stack's 1493; excluding tests, 406 against 642. Everything besides the content reader is the same as #1933.
The trade-offs:
gitand fsspec.datalad clonedoes.dataladCI job, while the current stack's run on every platform.dandisets/clone.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Generated by Claude Code