Repository navigation
Use datalad-fuse's remfile backend when available - #1957
Draft
CodyCBakerPhD wants to merge 4 commits into
Draft
CodyCBakerPhD wants to merge 4 commits into
CodyCBakerPhD wants to merge 4 commits into
Conversation
With the development version of datalad-fuse from datalad/datalad-fuse#131, use its RemoteFilesystemAdapter, which reads HDF5-based files such as NWB with remfile if installed (fsspec otherwise), and look up S3 exports for content without a registered URL. The released FsspecAdapter is still used with datalad-fuse 0.5.1. Test it in a new datalad-dev CI job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…talad-fuse-remfile Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## claude/validate-stream-via-datalad-fuse #1957 +/- ##
===========================================================================
+ Coverage 90.93% 90.97% +0.03%
===========================================================================
Files 94 94
Lines 14520 14547 +27
===========================================================================
+ Hits 13204 13234 +30
+ Misses 1316 1313 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…talad-fuse-remfile Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…talad-fuse-remfile Resolve the import conflict, and check the type of the file object wrapped by the one that pauses garbage collection in the remfile test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1956. This tries the development version of datalad-fuse from datalad/datalad-fuse#131, which adds pluggable backends, including remfile for HDF5-based files.
Changes
get_adapter()usesdatalad_fuse.adapter.RemoteFilesystemAdapter(dandiset.yaml: should become READONLY locally, with a comment, no metadata uploaded from it #131) when it is available, and falls back to the releaseddatalad_fuse.fsspec.FsspecAdapter(0.5.1) otherwise.remfileinstalled, NWB and other HDF5 files are read through remfile; other files still go through fsspec.datalad.fusefs.backendssetting.get_annexed_readable()also tries the S3 exporttree URLs from dandiset.yaml: should become READONLY locally, with a comment, no metadata uploaded from it #131 when git-annex lists no URL, for older datasets that lack versioned S3 URLs.validatedocs.test_annexed_readable_remfilechecks that an NWB file is opened through datalad-fuse'sRemfileWrapperand read with h5py over the local HTTP range server. It is skipped unless both dandiset.yaml: should become READONLY locally, with a comment, no metadata uploaded from it #131 andremfileare installed.datalad-devjob installs git-annex,remfileand datalad-fuse fromrefs/pull/131/head. The existingdataladjob keeps testing the PyPI release.Locally, the datalad-fuse and
validatestream tests pass with both datalad-fuse 0.5.1 (where the remfile test is skipped) and #131 plus remfile.Once #131 is released, the CI install can switch to that release and the
dataladextra's lower bound can be raised.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Generated by Claude Code