Skip to content

Use datalad-fuse's remfile backend when available - #1957

Draft
CodyCBakerPhD wants to merge 4 commits into
claude/validate-stream-via-datalad-fusefrom
claude/datalad-fuse-remfile
Draft

CodyCBakerPhD wants to merge 4 commits into
claude/validate-stream-via-datalad-fusefrom
claude/datalad-fuse-remfile

Conversation

@CodyCBakerPhD

Copy link
Copy Markdown
Contributor

Stacked on #1956. This tries the development version of datalad-fuse from datalad/datalad-fuse#131, which adds pluggable backends, including remfile for HDF5-based files.

Changes

Locally, the datalad-fuse and validate stream tests pass with both datalad-fuse 0.5.1 (where the remfile test is skipped) and #131 plus remfile.

Once #131 is released, the CI install can switch to that release and the datalad extra's lower bound can be raised.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr


Generated by Claude Code

claude added 2 commits October 6, 2026 21:21
With the development version of datalad-fuse from datalad/datalad-fuse#131,
use its RemoteFilesystemAdapter, which reads HDF5-based files such as NWB
with remfile if installed (fsspec otherwise), and look up S3 exports for
content without a registered URL.  The released FsspecAdapter is still
used with datalad-fuse 0.5.1.

Test it in a new datalad-dev CI job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…talad-fuse-remfile

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.97%. Comparing base (0be1c28) to head (7352f59).

Files with missing lines Patch % Lines
dandi/support/datalad_fuse.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           claude/validate-stream-via-datalad-fuse    #1957      +/-   ##
===========================================================================
+ Coverage                                    90.93%   90.97%   +0.03%     
===========================================================================
  Files                                           94       94              
  Lines                                        14520    14547      +27     
===========================================================================
+ Hits                                         13204    13234      +30     
+ Misses                                        1316     1313       -3     
Flag Coverage Δ
unittests 90.97% <93.75%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

claude added 2 commits October 6, 2026 22:52
…talad-fuse-remfile

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…talad-fuse-remfile

Resolve the import conflict, and check the type of the file object
wrapped by the one that pauses garbage collection in the remfile test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants