Skip to content

Fix get_metadata return annotation and import order in misctypes #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodyCBakerPhD merged 1 commit into from
Oct 6, 2026
Merged

Fix get_metadata return annotation and import order in misctypes #1950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dandi/metadata/nwb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
@metadata_cache.memoize_path
def get_metadata(
path: str | Path | Readable, digest: Digest | None = None
) -> dict | None:
) -> dict[str, Any]:
"""
Get "flatdata" from a .nwb file

Expand Down
3 changes: 1 addition & 2 deletions dandi/misctypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,9 +343,8 @@ class RemoteReadableAsset(Readable):

def open(self) -> IO[bytes]:
# Optional dependency:
import fsspec

from aiohttp import ClientTimeout
import fsspec

# We need to call open() on the return value of fsspec.open() because
# otherwise the filehandle will only be opened when used to enter a
Expand Down
Loading