Skip to content

Fix get_metadata return annotation and import order in misctypes - #1950

Merged
CodyCBakerPhD merged 1 commit into
masterfrom
claude/fix-get-metadata-annotation
Oct 6, 2026
Merged

CodyCBakerPhD merged 1 commit into
masterfrom
claude/fix-get-metadata-annotation

Conversation

@CodyCBakerPhD

Copy link
Copy Markdown
Contributor

@yarikoptic This seemed to cause some brief confusion during meeting today so split into pre-fix on its own

get_metadata() always returns a dict, never None.

The imports in RemoteReadableAsset.open() were not sorted as the pinned isort (5.12.0) of the pre-commit hook expects, so any change to dandi/misctypes.py re-sorted them.


Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr

get_metadata() always returns a dict, never None.  The imports in
RemoteReadableAsset.open() were not sorted as the pinned isort (5.12.0)
of the pre-commit hook expects, so any change to dandi/misctypes.py
re-sorted them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
@CodyCBakerPhD CodyCBakerPhD self-assigned this Oct 6, 2026
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.40%. Comparing base (8b6a1fc) to head (35db3ae).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1950      +/-   ##
==========================================
- Coverage   78.41%   78.40%   -0.01%     
==========================================
  Files          92       92              
  Lines       14130    14130              
==========================================
- Hits        11080    11079       -1     
- Misses       3050     3051       +1     
Flag Coverage Δ
unittests 78.40% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CodyCBakerPhD CodyCBakerPhD added the internal Changes only affect the internal API label Oct 6, 2026
@CodyCBakerPhD
CodyCBakerPhD merged commit 1bd8828 into master Oct 6, 2026
40 of 42 checks passed
@CodyCBakerPhD
CodyCBakerPhD deleted the claude/fix-get-metadata-annotation branch October 6, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes only affect the internal API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants