Skip to content

internal: (studio) update e2e tests for creating new tests in studio #32844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2025
+12 −8
Merged

internal: (studio) update e2e tests for creating new tests in studio #32844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75653f0
internal: (studio) update e2e tests for creating new tests in studio
astone123 Oct 28, 2025
cd76677
remove unnecessary logic
astone123 Oct 28, 2025
c15607d
fix navigation test
astone123 Oct 28, 2025
9c4607e
fix detached DOM error
astone123 Oct 28, 2025
dce7e8f
update helper
astone123 Oct 28, 2025
e0a9b37
Update packages/app/cypress/e2e/studio/studio-new-tests.cy.ts
astone123 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/app/cypress/e2e/studio/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function launchStudio ({ specName = 'spec.cy.js', createNewTestFromSuite
}

cy.findByTestId('studio-panel').should('be.visible')
cy.findByTestId('new-test-button').should('be.visible')
cy.findByTestId('create-test-button').should('be.visible')
} else {
cy.get('@runnable-wrapper')
.findByTestId('launch-studio')
Expand All @@ -55,8 +55,12 @@ export function launchStudio ({ specName = 'spec.cy.js', createNewTestFromSuite
}
}

export function inputNewTestName (name: string = 'new-test') {
cy.findByTestId('new-test-button').click()
export function inputNewTestName ({ name = 'new-test', creatingNewTestFromWelcomeScreen = true }: { name?: string, creatingNewTestFromWelcomeScreen?: boolean } = {}) {
if (creatingNewTestFromWelcomeScreen) {
// we only need to click the new test button if we are not creating a new test from a suite or spec header
cy.findByTestId('new-test-button').click()
}

cy.findByTestId('test-name-input').type(name)
cy.findByTestId('create-test-button').click()

Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/studio/studio-navigation.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('Cypress Studio - Navigation and URL Management', () => {
it('updates the AUT url when creating a new test', () => {
launchStudio({ specName: 'navigation.cy.js', createNewTestFromSuite: true })

inputNewTestName()
inputNewTestName({ creatingNewTestFromWelcomeScreen: false })

cy.findByTestId('aut-url-input').should('have.focus').type('cypress/e2e/navigation.html{enter}')

Expand Down
8 changes: 4 additions & 4 deletions packages/app/cypress/e2e/studio/studio-new-tests.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('Cypress Studio - New Test Creation', () => {
it('creates a new test from spec header', () => {
launchStudio({ specName: 'spec-w-visit.cy.js', createNewTestFromSpecHeader: true })

inputNewTestName()
inputNewTestName({ creatingNewTestFromWelcomeScreen: false })

cy.contains('new-test').click()

Expand Down Expand Up @@ -128,10 +128,10 @@ describe('studio functionality', () => {
it('creates a new test for a specific suite with the url already defined', () => {
launchStudio({ specName: 'spec-w-visit.cy.js', createNewTestFromSuite: true })

// create a new test from a specific suite
cy.findByTestId('create-new-test-from-suite').click()
inputNewTestName({ creatingNewTestFromWelcomeScreen: false })

inputNewTestName()
// make sure that the visit has run and we're recording studio commands
cy.get('[data-cy="record-button-recording"]').should('be.visible')

cy.percySnapshot()

Expand Down
Loading