internal: (studio) update e2e tests for creating new tests in studio #32844
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
astone123
commented
Oct 28, 2025
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
studio-welcome-test-update
|
| Run status |
|
| Run duration | 16m 48s |
| Commit |
|
| Committer | Adam Stone-Lord |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
132
|
Skipped
|
0
|
Passing
|
5595
|
| View all changes introduced in this branch ↗︎ | |
mabela416
reviewed
Oct 28, 2025
mabela416
approved these changes
Oct 28, 2025
mschile
reviewed
Oct 28, 2025
Co-authored-by: Matt Schile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We updated the screen that the user sees in the studio panel depending on the button that they click to open the panel. This PR updates the e2e tests to match that behavior. It also fixes an issue where we were getting a detached DOM error when asserting on elements in the AUT iframe.
Detached DOM issue:
https://cloud.cypress.io/projects/ypt4pf/runs/66905/overview/ff0fae1f-3022-4865-9f74-a235d56437c0/replay?roarHideRunsWithDiffGroupsAndTags=1&ts=1761658484931.7&att=1
New test button issues:
https://cloud.cypress.io/projects/ypt4pf/runs/66914/overview/ca6734e3-2711-4abc-9cea-68e1d393dc88?roarHideRunsWithDiffGroupsAndTags=1
Steps to test
Run the tests in
studio-new-tests.cy.tsHow has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?Note
Refactors Studio test helper and updates e2e specs to align with new new-test flow and
create-test-buttonselector, including conditional handling when launched from suite/spec header.packages/app/cypress/e2e/studio/helper.ts):inputNewTestNameto accept{ name, creatingNewTestFromWelcomeScreen }and conditionally clicknew-test-buttonbased on context.create-test-buttoninstead ofnew-test-button.studio-navigation.cy.ts):inputNewTestName({ creatingNewTestFromWelcomeScreen: false })when creating tests from a suite.studio-new-tests.cy.ts):inputNewTestName({ creatingNewTestFromWelcomeScreen: false })for suite/spec-header flows.create-new-test-from-suite(now handled by helper) and ensure recording state before proceeding.Written by Cursor Bugbot for commit e0a9b37. This will update automatically on new commits. Configure here.