Do not evaluate programs on stuck terms #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansjoergschurr
approved these changes
Feb 7, 2025
Merged
ajreynol
added a commit
that referenced
this pull request
Feb 18, 2025
This adds a new class of statistics that counts the number of calls to programs, which can enable more fine grained profiling. This also corrects a minor inconsistency in oracles/programs introduced in #110, where the check for "stuck" terms should be applied uniformly for programs and oracles. Example output: ``` ======================================================================== mkExprCount = 793 newExprCount = 700 deleteExprCount = 69 symCount = 226 litCount = 7 time = 23904 ==================================================================================== Rule # t t/# #mkExpr ==================================================================================== arith_sum_ub: 1 1565 (6.5%) 1565 46 arith_mult_neg: 1 753 (3.2%) 753 25 arith_mult_pos: 1 262 (1.1%) 262 22 ==================================================================================== Program # ==================================================================================== is_arith_type: 18 arith_typeunion_nary: 13 mk_arith_sum_ub: 4 arith_rel_sum: 3 mk_arith_sum_ub_step: 3 arith_rel_inv: 1 mk_arith_mult_pos: 1 mk_arith_mult_neg: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies our definition so that unapplied literal operators, programs and oracles are considered "evaluatable".
Modifies the evaluator to not execute programs that have stuck terms.
This leads to better error messages, in particular for users passing evaluatable functions as higher-order arguments, which is not currently supported.
After my latest commit on this PR (to undo an oversimplification to the code), I have verified that the current signature in cvc5 is not impacted by this change.