-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --stats-all #119
Add --stats-all #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, see my comment though.
Also it looks like you didn't run the code formatter ^^
src/stats.cpp
Outdated
ssCheck << sss.str() << ": " << rs.d_time; | ||
ssMkExpr << sss.str() << ": " << rs.d_mkExprCount; | ||
} | ||
else | ||
{ | ||
sss << ": "; | ||
ss << std::right << std::setw(28) << sss.str() << rs.toString(totalTime) << std::endl; | ||
ss << std::right << std::setw(40) << sss.str(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have names for those streams that aren't just ss
and sss
:P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed sss
to ssExpr
:)
src/stats.cpp
Outdated
@@ -42,13 +42,11 @@ void RuleStat::increment(Stats& s) | |||
std::string RuleStat::toString(std::time_t totalTime) const | |||
{ | |||
std::stringstream ss; | |||
ss << std::left << std::setw(7) << d_count; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this move down to line 48? it seems bit out of place here
This adds a new class of statistics that counts the number of calls to programs, which can enable more fine grained profiling.
This also corrects a minor inconsistency in oracles/programs introduced in #110, where the check for "stuck" terms should be applied uniformly for programs and oracles.
Example output: