Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --stats-all #119

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Add --stats-all #119

merged 6 commits into from
Feb 18, 2025

Conversation

ajreynol
Copy link
Member

This adds a new class of statistics that counts the number of calls to programs, which can enable more fine grained profiling.

This also corrects a minor inconsistency in oracles/programs introduced in #110, where the check for "stuck" terms should be applied uniformly for programs and oracles.

Example output:

========================================================================
mkExprCount = 793
newExprCount = 700
deleteExprCount = 69
symCount = 226
litCount = 7
time = 23904
====================================================================================
                                  Rule  #      t                t/#       #mkExpr   
====================================================================================
                          arith_sum_ub: 1      1565 (6.5%)      1565      46        
                        arith_mult_neg: 1      753 (3.2%)       753       25        
                        arith_mult_pos: 1      262 (1.1%)       262       22        
====================================================================================
                               Program  #      
====================================================================================
                         is_arith_type: 18
                  arith_typeunion_nary: 13
                       mk_arith_sum_ub: 4
                         arith_rel_sum: 3
                  mk_arith_sum_ub_step: 3
                         arith_rel_inv: 1
                     mk_arith_mult_pos: 1
                     mk_arith_mult_neg: 1

Copy link
Contributor

@hansjoergschurr hansjoergschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, see my comment though.
Also it looks like you didn't run the code formatter ^^

src/stats.cpp Outdated
ssCheck << sss.str() << ": " << rs.d_time;
ssMkExpr << sss.str() << ": " << rs.d_mkExprCount;
}
else
{
sss << ": ";
ss << std::right << std::setw(28) << sss.str() << rs.toString(totalTime) << std::endl;
ss << std::right << std::setw(40) << sss.str();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have names for those streams that aren't just ss and sss :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed sss to ssExpr :)

src/stats.cpp Outdated
@@ -42,13 +42,11 @@ void RuleStat::increment(Stats& s)
std::string RuleStat::toString(std::time_t totalTime) const
{
std::stringstream ss;
ss << std::left << std::setw(7) << d_count;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this move down to line 48? it seems bit out of place here

@ajreynol ajreynol merged commit afa7ba1 into main Feb 18, 2025
20 checks passed
@ajreynol ajreynol deleted the ethosNewStat branch February 18, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants