-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to disable screen view usage #190
Merged
+176
−40
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ class CustomerIOSDKConfig { | |
final String? cdnHost; | ||
final int? flushAt; | ||
final int? flushInterval; | ||
final ScreenView? screenViewUse; | ||
final InAppConfig? inAppConfig; | ||
final PushConfig pushConfig; | ||
|
||
|
@@ -29,6 +30,7 @@ class CustomerIOSDKConfig { | |
this.cdnHost, | ||
this.flushAt, | ||
this.flushInterval, | ||
this.screenViewUse, | ||
this.inAppConfig, | ||
PushConfig? pushConfig, | ||
}) : pushConfig = pushConfig ?? PushConfig(); | ||
|
@@ -45,10 +47,11 @@ class CustomerIOSDKConfig { | |
throw ArgumentError('cdpApiKey cannot be null'); | ||
} | ||
|
||
final region = prefs.getString(_PreferencesKey.region) != null | ||
? Region.values.firstWhere( | ||
(e) => e.name == prefs.getString(_PreferencesKey.region)) | ||
: null; | ||
final region = | ||
prefs.getEnumValueFromPrefs(_PreferencesKey.region, Region.values); | ||
final screenViewUse = prefs.getEnumValueFromPrefs( | ||
_PreferencesKey.screenViewUse, ScreenView.values); | ||
|
||
return CustomerIOSDKConfig( | ||
cdpApiKey: cdpApiKey, | ||
migrationSiteId: prefs.getString(_PreferencesKey.migrationSiteId), | ||
|
@@ -63,27 +66,11 @@ class CustomerIOSDKConfig { | |
cdnHost: prefs.getString(_PreferencesKey.cdnHost), | ||
flushAt: prefs.getInt(_PreferencesKey.flushAt), | ||
flushInterval: prefs.getInt(_PreferencesKey.flushInterval), | ||
screenViewUse: screenViewUse, | ||
inAppConfig: InAppConfig( | ||
siteId: prefs.getString(_PreferencesKey.migrationSiteId) ?? ""), | ||
); | ||
} | ||
|
||
Map<String, dynamic> toMap() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't see it being used anywhere so removed it |
||
return { | ||
'cdpApiKey': cdpApiKey, | ||
'migrationSiteId': migrationSiteId, | ||
'region': region?.name, | ||
'logLevel': debugModeEnabled, | ||
'screenTrackingEnabled': screenTrackingEnabled, | ||
'autoTrackDeviceAttributes': autoTrackDeviceAttributes, | ||
'apiHost': apiHost, | ||
'cdnHost': cdnHost, | ||
'flushAt': flushAt, | ||
'flushInterval': flushInterval, | ||
'inAppConfig': inAppConfig?.toMap(), | ||
'pushConfig': pushConfig.toMap(), | ||
}; | ||
} | ||
} | ||
|
||
extension ConfigurationPreferencesExtensions on SharedPreferences { | ||
|
@@ -128,8 +115,18 @@ extension ConfigurationPreferencesExtensions on SharedPreferences { | |
result = result && | ||
await setOrRemoveInt( | ||
_PreferencesKey.flushInterval, config.flushInterval); | ||
result = result && | ||
await setOrRemoveString( | ||
_PreferencesKey.screenViewUse, config.screenViewUse?.name); | ||
return result; | ||
} | ||
|
||
T? getEnumValueFromPrefs<T extends Enum>(String key, List<T> values) { | ||
final storedValue = getString(key); | ||
if (storedValue == null) return null; | ||
|
||
return values.firstWhere((e) => e.name == storedValue); | ||
} | ||
} | ||
|
||
class _PreferencesKey { | ||
|
@@ -143,4 +140,5 @@ class _PreferencesKey { | |
static const cdnHost = 'CDN_HOST'; | ||
static const flushAt = 'FLUSH_AT'; | ||
static const flushInterval = 'FLUSH_INTERVAL'; | ||
static const screenViewUse = 'SCREEN_VIEW_USE'; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated so we can use data pipeline release