feat: add option to disable screen view usage #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
commented
Jan 1, 2025
| @@ -1,7 +1,7 @@ | |||
| # ------------- | |||
| # This code only used internally for Customer.io testing | |||
| require 'open-uri' | |||
| IO.copy_stream(URI.open('https://raw.githubusercontent.com/customerio/customerio-ios/v2/scripts/cocoapods_override_sdk.rb'), "/tmp/override_cio_sdk.rb") | |||
| IO.copy_stream(URI.open('https://raw.githubusercontent.com/customerio/customerio-ios/main/scripts/cocoapods_override_sdk.rb'), "/tmp/override_cio_sdk.rb") | |||
There was a problem hiding this comment.
Updated so we can use data pipeline release
| inAppConfig: InAppConfig( | ||
| siteId: prefs.getString(_PreferencesKey.migrationSiteId) ?? ""), | ||
| ); | ||
| } | ||
|
|
||
| Map<String, dynamic> toMap() { |
There was a problem hiding this comment.
I didn't see it being used anywhere so removed it
Shahroz16
reviewed
Jan 2, 2025
|
iOS SDK version is already updated to current latest, but we plan to roll out another fix on iOS early next week. We'll hold off on merging this PR until the fix is released and update iOS version to latest again after iOS release. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
## [2.1.0](2.0.0...2.1.0) (2025-01-06) ### Features * add option to disable screen view usage ([#190](#190)) ([b4a4fed](b4a4fed))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: MBL-758
Changes
screenViewUseconfig to disable sending screen view events to server, allowing local usage only4.5.0and iOS SDK to version3.7.1to support newScreenViewconfiguration optionscreenViewUseconfiguration to native SDKs for appropriate handlingscreenViewUseconfiguration to be modified from the settings page for testing purposesScreenViewOptionsAnalytics-> Sends all screen events to the server (same as before) - Default behaviorInApp-> Retains screen events locally for in-app use onlySample Usage
Screenshot (Sample App)