Update TB for BNW s2 bug + remove recv_aborted_by_reset protocol - #318
Merged
Conversation
… active at the end)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the test-bench for the BNW
s2bug (AXI-Stream implementation not holdingtlaststable) so thatresetdoes not become 0 (active) at the end of the waveform. This was a one line change in the BNW test-bench, changingPI_M_AXIS_ARESETN <= 1'b1toPI_M_AXIS_ARESETN <= 1'b0in the last cycle of the waveform. (I've included the Verilog code for the BNW test bench in this PR as well.) I then regenerated the buggy + fixed waveforms using this updated version of the BNW test-benchThe updated version of the fixed waveform looks like this (note that
M_AXIS_ARESETNremains 1 towards the end of the waveform and no longer suddenly becomes 0):Since the waveform has been updated, this PR also removes the
recv_aborted_by_resetprotocol froms2.prot. On the fixed waveform, the BI now infers:If we pass the
--include-in-progressflag to the BI, we also get:This indicates that the final
recv(7, ...)transaction did not complete in the waveform, which is what we expect since we see thatready = 0during the last 4 cycles of the waveform above (so the data transfer for7never happens).The BI continues to report an error on the (updated) buggy waveform, but we now only have an error message for the
recvtransaction (we no longer have an error forrecv_aborted_by_reset, since this transaction has been deleted):