Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEs only #302

Closed
wants to merge 3 commits into from
Closed

AEs only #302

wants to merge 3 commits into from

Conversation

Peter230655
Copy link
Contributor

opty can solve equations of motion which only consist of algebraic equations. I simply removed the lines which test for differential equations.
Surely this is not the main goal of opty!
Still it might be useful to have this option, say, to get th steady state behaviour of a set of differential equations - in any case it does not hurt to have the option, without stressing it,or even pointing it out in the documentation.

@Peter230655
Copy link
Contributor Author

I think, it is bound to fail test_for_algebraic_eoms because I precisely removed the lines in direct_collocation.py testing for this.
This additional possible feature is not very important, one can always add a dummy differential equation to the eoms.
@moorepants Best I simply close this PR?

@moorepants
Copy link
Member

The purpose of opty has always been strictly for solving optimal control problems that involve differential equations. There are many other tools that solve other optimization problems, including optimization of a set of algebraic equations. So unless you have a convincing argument as to why opty should support this (e.g. no other tool in Python does it), then I don't think we should support algebraic-only equations.

@moorepants
Copy link
Member

Secondly, if we merge this support, you will have to rewrite much of the documentation to explain the theory and all the details of this support. The documentation is all currently written from the perspective that this tool solves optimal control problems in the time domain.

@Peter230655
Copy link
Contributor Author

I agree! It would distract from opty's main purpose without really adding anything substantial.

@Peter230655 Peter230655 deleted the AEs-only branch January 20, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants