Network support #39
Open
Network support #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haardik Dharma <[email protected]>
Signed-off-by: satakshigarg <[email protected]>
| // CivoNetworkSpec holds the networkConfig | ||
| type CivoNetworkSpec struct { | ||
| xpv1.ResourceSpec `json:",inline"` | ||
| NetworkConfig CivoNetworkConfig `json:"networkConfig"` |
There was a problem hiding this comment.
Suggested change
| NetworkConfig CivoNetworkConfig `json:"networkConfig"` | |
| Label string `json:"label"` | |
There was a problem hiding this comment.
We don't need the CivoNetworkConfig struct here tbh
There was a problem hiding this comment.
We can remove region as that's something we get from ProviderConfig
| if !ok { | ||
| return managed.ExternalCreation{}, errors.New(errNotCivoNetwork) | ||
| } | ||
| civoNetwork, err := e.civoClient.GetNetwork(cr.Status.AtProvider.ID) |
There was a problem hiding this comment.
Do not rely on Status here. We should do a FindNetworks call to find cr.Spec.Label. If it's not found, create it
| return managed.ExternalUpdate{}, errors.New(errNotCivoNetwork) | ||
| } | ||
|
|
||
| err := e.civoClient.UpdateNetwork(cr.Status.AtProvider.ID, cr.Spec.NetworkConfig.Label) |
There was a problem hiding this comment.
Use FindNetworks call with cr.spec.label rather than relying on status
| } | ||
| cr.SetConditions(xpv1.Deleting()) | ||
| err := e.civoClient.DeleteNetwork(cr.Status.AtProvider.ID) | ||
| return errors.Wrap(err, errDeleteNetwork) |
There was a problem hiding this comment.
Can this not be just return err
| if err != nil { | ||
| return err | ||
| } | ||
| _, err = c.civoGoClient.DeleteNetwork(network.ID) |
There was a problem hiding this comment.
If the network is not found, we should return nil rather than an error
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added example .yaml & IPv6 support to Network spec