Network support for Civo Crossplane Provider #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haardikdharma10
force-pushed
the
network-support
branch
from
7248df0 to
4b51845
Compare
apis/civo/network/v1alpha1/types.go
Outdated
| // CivoNetworkSpec holds the networkConfig | ||
| type CivoNetworkSpec struct { | ||
| xpv1.ResourceSpec `json:",inline"` | ||
| NetworkConfig CivoNetworkConfig `json:"networkConfig"` |
There was a problem hiding this comment.
Can we use the fields here directly i.e?
Suggested change
| NetworkConfig CivoNetworkConfig `json:"networkConfig"` | |
| Label string `json:"label"` | |
| Region string `json:"region"` |
| // DeleteNetwork deletes a network on Civo. | ||
| func (c *CivoClient) DeleteNetwork(id string) error { | ||
| network, err := c.civoGoClient.GetNetwork(id) | ||
| if err != nil { |
There was a problem hiding this comment.
If it is not found, we should return nil
Signed-off-by: Haardik Dharma <[email protected]>
Signed-off-by: Haardik Dharma <[email protected]>
Signed-off-by: Haardik Dharma <[email protected]>
Signed-off-by: Haardik Dharma <[email protected]>
Signed-off-by: Haardik Dharma <[email protected]>
Signed-off-by: Haardik Dharma <[email protected]>
Signed-off-by: Haardik Dharma <[email protected]>
Signed-off-by: Haardik Dharma <[email protected]>
haardikdharma10
force-pushed
the
network-support
branch
from
fdcedd7 to
50db990
Compare
Signed-off-by: Haardik Dharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #24
I have:
make reviewable testto ensure this PR is ready for review.