Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/crc/adminhelper/hosts_unix.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package adminhelper

Expand Down
2 changes: 1 addition & 1 deletion pkg/crc/cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (c *Cache) GetExecutableName() string {
*
* It returns <version> as a string
*/
func getVersionGeneric(executablePath string, args ...string) (string, error) { //nolint:deadcode,unused
func getVersionGeneric(executablePath string, args ...string) (string, error) { //nolint:unused
stdOut, _, err := crcos.RunWithDefaultLocale(executablePath, args...)
if err != nil {
logging.Debugf("failed to run executable %s: %v", executablePath, err)
Expand Down
1 change: 0 additions & 1 deletion pkg/crc/daemonclient/transport_unix.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package daemonclient

Expand Down
4 changes: 2 additions & 2 deletions pkg/crc/gpg/gpg.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"github.com/ProtonMail/go-crypto/openpgp"
"github.com/crc-org/crc/v2/pkg/crc/constants"
"github.com/crc-org/crc/v2/pkg/crc/logging"
goOpenpgp "golang.org/x/crypto/openpgp" //nolint
goClearsign "golang.org/x/crypto/openpgp/clearsign" //nolint
goOpenpgp "golang.org/x/crypto/openpgp" //nolint:staticcheck
goClearsign "golang.org/x/crypto/openpgp/clearsign" //nolint:staticcheck
)

func Verify(filePath, signatureFilePath string) error {
Expand Down
6 changes: 5 additions & 1 deletion pkg/crc/machine/generate_bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ func (client *client) GenerateBundle(forceStop bool) error {
if err != nil {
return err
}
defer copier.Cleanup() //nolint
defer func() {
if err := copier.Cleanup(); err != nil {
logging.Errorf("copier.Cleanup failed: %v", err)
}
}()
customBundleDir := copier.CachedPath()

if err := copier.CopyKubeConfig(); err != nil {
Expand Down
1 change: 0 additions & 1 deletion pkg/crc/machine/generate_bundle_nonlinux.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !linux
// +build !linux

package machine

Expand Down
1 change: 0 additions & 1 deletion pkg/crc/machine/libvirt/constants.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build linux || build
// +build linux build

package libvirt

Expand Down
2 changes: 1 addition & 1 deletion pkg/crc/machine/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ func enableEmergencyLogin(sshRunner *crcssh.Runner) error {
charset := "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
b := make([]byte, 8)
for i := range b {
b[i] = charset[rand.Intn(len(charset))] //nolint
b[i] = charset[rand.Intn(len(charset))] //nolint:gosec
}
if err := os.WriteFile(constants.PasswdFilePath, b, 0600); err != nil {
return err
Expand Down
1 change: 0 additions & 1 deletion pkg/crc/machine/vfkit/constants.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build darwin || build
// +build darwin build

package vfkit

Expand Down
1 change: 0 additions & 1 deletion pkg/crc/manpages/manpages_unix.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package manpages

Expand Down
1 change: 0 additions & 1 deletion pkg/crc/manpages/manpages_unix_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package manpages

Expand Down
4 changes: 2 additions & 2 deletions pkg/crc/preflight/labels.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const (

// Keep it last
// will be used in OS-specific go files to extend LabelName
lastLabelName // nolint
lastLabelName //nolint:unused
)

type LabelValue uint32
Expand All @@ -31,7 +31,7 @@ const (

// Keep it last
// will be used in OS-specific go files to extend LabelValue
lastLabelValue // nolint
lastLabelValue //nolint:unused
)

var (
Expand Down
1 change: 0 additions & 1 deletion pkg/crc/preflight/preflight_checks_network_linux.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build linux
// +build linux

package preflight

Expand Down
1 change: 0 additions & 1 deletion pkg/crc/preflight/preflight_checks_nonlinux.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !linux
// +build !linux

package preflight

Expand Down
1 change: 0 additions & 1 deletion pkg/crc/preflight/preflight_checks_unix.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package preflight

Expand Down
1 change: 0 additions & 1 deletion pkg/crc/preflight/preflight_ubuntu_linux.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build linux
// +build linux

package preflight

Expand Down
1 change: 0 additions & 1 deletion pkg/crc/preflight/preflight_ubuntu_linux_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build linux
// +build linux

package preflight

Expand Down
1 change: 0 additions & 1 deletion pkg/crc/ssh/keys_unix.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package ssh

Expand Down
1 change: 0 additions & 1 deletion pkg/os/linux/release_info.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build linux
// +build linux

package linux

Expand Down
1 change: 0 additions & 1 deletion pkg/os/linux/release_info_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build linux
// +build linux

package linux

Expand Down
1 change: 0 additions & 1 deletion pkg/os/shell/shell_unix.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package shell

Expand Down
1 change: 0 additions & 1 deletion pkg/os/shell/shell_unix_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package shell

Expand Down
1 change: 0 additions & 1 deletion pkg/os/util_unix.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package os

Expand Down
2 changes: 1 addition & 1 deletion pkg/os/windows/win32/domains_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/yusufpapurcu/wmi"
)

// nolint
//nolint:staticcheck
type Win32_ComputerSystem struct {
Partofdomain bool
}
Expand Down
1 change: 0 additions & 1 deletion test/extended/os/applescript/applescript.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package applescript

Expand Down
Loading