lint: Remove usage of //+build, and some //nolint improvements #4979
Conversation
This has been superseded by //go:build quite some time ago, and go vet started erroring out when it finds these, see crc-org#4975 Signed-off-by: Christophe Fergeau <[email protected]>
This indicates the linter we want to ignore, in case other linters would find issues unrelated to the one we want to ignore. Signed-off-by: Christophe Fergeau <[email protected]>
The 'deadcode' linter is no longer used and causes warnings from `make cross-lint` Signed-off-by: Christophe Fergeau <[email protected]>
Ignoring the error forces us to use a //nolint directive. We could ignore it with `_ = copier.Cleanup()`, but we can as well log it with `logging.Errorf`. Signed-off-by: Christophe Fergeau <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cfergeau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Main goal is to fix the linting errors which appear with #4975