Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 20, 2025

Bumps golang.org/x/tools from 0.37.0 to 0.38.0.

Commits
  • a22b5e8 go.mod: update golang.org/x dependencies
  • 4bbcc9f all: use reflect.TypeFor instead of reflect.TypeOf when we have known the type
  • 122c93a internal/refactor: AddImport: remove unnecessary result
  • 76aace8 internal/analysisinternal: rationalize
  • 8cf2d63 gopls/internal/golang: add condition for enabling package move
  • 1f054fd x/tools: downgrade token.FileSet parameters to token.File
  • 44e71e5 go/analysis/passes/printf: check anonymous functions too
  • 9095e9b internal/analysisinternal: extract DeleteVar
  • 62a1b26 internal/analysisinternal: IsChildOf(Cursor, edge.Kind) bool
  • d32fb50 internal/analysisinternal: export EnclosingFile
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 20, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from cfergeau and lilyLuLiu October 20, 2025 17:14
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@praveenkumar
Copy link
Member

This need more improvement to fix the CI before merge

/hold

@cfergeau
Copy link
Contributor

CI fails with:

 #10 24.59 cd tools && GOBIN="/root/rpmbuild/BUILD/crc-2.55.0-4.19.13/tools/bin" go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint
#10 74.01 "/root/rpmbuild/BUILD/crc-2.55.0-4.19.13/tools/bin"/golangci-lint run
Error: #10 178.7 pkg/crc/adminhelper/hosts_unix.go:2:1: buildtag: +build line is no longer needed (govet)
#10 178.7 // +build !windows
#10 178.7 ^
Error: #10 178.7 pkg/crc/daemonclient/transport_unix.go:2:1: buildtag: +build line is no longer needed (govet)
#10 178.7 // +build !windows
#10 178.7 ^
Error: #10 178.7 pkg/crc/machine/libvirt/constants.go:2:1: buildtag: +build line is no longer needed (govet)

cfergeau added a commit to cfergeau/crc that referenced this pull request Oct 23, 2025
This has been superseded by //go:build quite some time ago, and go vet
started erroring out when it finds these, see crc-org#4975

Signed-off-by: Christophe Fergeau <[email protected]>
@cfergeau
Copy link
Contributor

This need more improvement to fix the CI before merge

/hold

This should be fixed by #4979

praveenkumar pushed a commit that referenced this pull request Oct 28, 2025
This has been superseded by //go:build quite some time ago, and go vet
started erroring out when it finds these, see #4975

Signed-off-by: Christophe Fergeau <[email protected]>
@praveenkumar
Copy link
Member

@dependabot rebase

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.37.0 to 0.38.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.37.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-version: 0.38.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/tools/golang.org/x/tools-0.38.0 branch from d67a8e4 to 8641e02 Compare October 28, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file do-not-merge/hold go Pull requests that update Go code needs-ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants