Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linalg.conj.conjugated] Rearrange to match P3050R3 #7506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Dec 19, 2024

This was the wording requested by LWG and approved in P3050R3, but I mistakenly put P3050R2 in the straw polls.

This was the wording requested by LWG and approved in P3050R3, but I
mistakenly put P3050R2 in the straw polls.
@jwakely
Copy link
Member Author

jwakely commented Dec 19, 2024

@mhoemmen another fix for an incorrect straw poll

source/numerics.tex Outdated Show resolved Hide resolved
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared this against P3050R3; it looks good! Thanks! : - )

Comment on lines +12839 to +12840
otherwise,
\tcode{a}, if \tcode{is_same_v<A, Accessor>} is \tcode{true};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this editorially-obviously related to the struck text talking about conj(E) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to read the preceding paragraph too. In R2 (as applied to the draft) the text in p2 talking about conj(E) was duplicating exactly the condition in 1.3, which was just unnecessarily verbose and repetitive.

We don't need to repeat exactly the two conditions in 1.2 and 1.3 as 2.2 and 2.3, we can just say that if the type A determined in p2 is Accessor, then we return a.

So this is replacing everything in p2 that repeats conditions from p1 by specifying the return value in terms of what was determined in p1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words, previously we had:

  • (1.2) Accessor if remove_cvref_t<ElementType> is an arithmetic type; otherwise,

  • (1.3) Accessor if the expression conj(E) is not valid for any subexpression E whose type T is expression-equivalent to remove_cvref_t<ElementType> with overload resolution performed in a context that includes the declaration template<class T> conj(const T&) = delete;; otherwise,

and

  • (2.2) a if remove_cvref_t<ElementType> is an arithmetic type; otherwise,

  • (2.3) a if the expression conj(E) is not valid for any subexpression E whose type T is expression-equivalent to remove_cvref_t<ElementType> with overload resolution performed in a context that includes the declaration template<class T> conj(const T&) = delete;; otherwise,

But now p2 just says we return a if it's already the right type and doesn't need to be transformed.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation.

source/numerics.tex Outdated Show resolved Hide resolved
Co-authored-by: timsong-cpp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants