Avoid incorrect sentence parsing option on types #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Nov 27, 2024
jensmaurer
added
the
changes requested
mrussoLuxoft
force-pushed
the
clarify__dcl_spec_auto_general__1
branch
from
66896cf to
a0d3748
Compare
jensmaurer
removed
the
changes requested
|
Please fix the commit title per https://github.com/cplusplus/draft/wiki/Commit-message-format |
mrussoLuxoft
force-pushed
the
clarify__dcl_spec_auto_general__1
branch
2 times, most recently
from
789b163 to
63cef78
Compare
|
commit message amended |
jensmaurer
requested changes
Nov 28, 2024
mrussoLuxoft
force-pushed
the
clarify__dcl_spec_auto_general__1
branch
from
63cef78 to
b357f32
Compare
jensmaurer
requested changes
Nov 28, 2024
Avoid incorrect sentence parsing option on parameter type. Text may be ambiguous in the sense that it may be interpreted both as the type of any of three things (incorrect) or the type of a parameter of any of three things (correct). Despite the former interpretation does not make sense as a lambda expression has never an explicit type, it would still be useful to avoid ambiguity in sentence parsing. Signed-off-by: Mauro Russo <[email protected]>
mrussoLuxoft
force-pushed
the
clarify__dcl_spec_auto_general__1
branch
from
b357f32 to
8933940
Compare
jensmaurer
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the Issue #7453 proposing multiple changes to clarify the text in [dcl.spec.auto.general]
However, a PR has been created for each specific change.
In [dcl.spec.auto.general]-p2, the verbal form
The type of a parameter-declaration of a function declaration, lambda-expression, or template-
parameter ...
may be ambiguous in the sense that it may be interpreted both as the type of any of three things (incorrect) or the type of a parameter of any of three things (correct).
In a discussion on std-discussion, it was highlighted that the former interpretation does not make sense as a lambda expression has never an explicit type, however it was still agreed that the verbal syntax should be improved (https://lists.isocpp.org/std-discussion/2024/11/2724.php).