remove matthiasnoback dependency for increased Symfony compatibility #39
Conversation
davidpocar
force-pushed
the
remove-matthiasnoback-dependency-for-increased-symfony-compatibility
branch
2 times, most recently
from
bc0c530 to
24151cb
Compare
| $container->registerExtension(new ConsistenceJmsSerializerExtension()); | ||
|
|
||
| foreach ($container->getExtensions() as $extension) { | ||
| $extension->load([], $container); | ||
| } |
There was a problem hiding this comment.
I think this should also be included in the createContainer() method?
Imagine, that there are several test cases in this test, all of them would duplicate this code otherwise, right?
Or in the case of load() maybe if not directly in createContainer(), then it should be again a separate method. This probably depends on whether there is a chance that something else needs to be done between container creation and load() in test code (e.g. something that we would not want to be handled in createContaiener() as well). I mean obviously not here, but please look also at the other repositories where we are handling this.
| string $tagName | ||
| ): void | ||
| { | ||
| $tagExists = false; |
There was a problem hiding this comment.
I think all of this can be implemented just with Consistence\Type\ArrayType\ArrayType::containsValueByValueCallback()? Or am I missing something? :)
davidpocar
force-pushed
the
remove-matthiasnoback-dependency-for-increased-symfony-compatibility
branch
2 times, most recently
from
5064a22 to
507702b
Compare
davidpocar
force-pushed
the
remove-matthiasnoback-dependency-for-increased-symfony-compatibility
branch
from
507702b to
902c89d
Compare
2 participants
No description provided.