remove matthiasnoback dependency for increased Symfony compatibility

Author: davidpocar

.github/workflows/ci.yml

@@ -139,10 +139,10 @@ jobs:
                     - '7.3'
                     - '7.4'
                 symfony-version:
-                    # - '4.0' matthiasnoback/symfony-dependency-injection-test 4.3.0 requires symfony/config ^4.4 || ^5.3 || ^6.0
-                    # - '4.1' matthiasnoback/symfony-dependency-injection-test 4.3.0 requires symfony/config ^4.4 || ^5.3 || ^6.0
-                    # - '4.2' matthiasnoback/symfony-dependency-injection-test 4.3.0 requires symfony/config ^4.4 || ^5.3 || ^6.0
-                    # - '4.3' matthiasnoback/symfony-dependency-injection-test 4.3.0 requires symfony/config ^4.4 || ^5.3 || ^6.0
+                    - '4.0'
+                    - '4.1'
+                    - '4.2'
+                    - '4.3'
                     - '4.4'
                 composer-dependencies:
                     - 'highest'

build/composer-dependency-analyser.config.php

@@ -27,7 +27,6 @@
 $config = $config->ignoreErrorsOnPackages([
 	'consistence/coding-standard',
 	'phing/phing',
-	'phpunit/phpunit',
 	'php-parallel-lint/php-console-highlighter',
 	'php-parallel-lint/php-parallel-lint',
 ], [ErrorType::UNUSED_DEPENDENCY]);

composer.json

@@ -20,7 +20,6 @@
 	},
 	"require-dev": {
 		"consistence/coding-standard": "3.10.1",
-		"matthiasnoback/symfony-dependency-injection-test": "4.3",
 		"php-parallel-lint/php-console-highlighter": "1.0",
 		"php-parallel-lint/php-parallel-lint": "1.3.2",
 		"phing/phing": "2.17.2",

tests/DependencyInjection/ConsistenceJmsSerializerExtensionTest.php

@@ -5,34 +5,87 @@
 namespace Consistence\JmsSerializer\SymfonyBundle\DependencyInjection;
 
 use Consistence\JmsSerializer\Enum\EnumSerializerHandler;
+use PHPUnit\Framework\Assert;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
 
-class ConsistenceJmsSerializerExtensionTest extends \Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractExtensionTestCase
+class ConsistenceJmsSerializerExtensionTest extends \PHPUnit\Framework\TestCase
 {
 
-	/**
-	 * @return \Symfony\Component\DependencyInjection\Extension\ExtensionInterface[]
-	 */
-	protected function getContainerExtensions(): array
+	public function testRegisterSerializerHandler(): void
 	{
-		return [
-			new ConsistenceJmsSerializerExtension(),
-		];
+		$container = self::createContainer();
+		$container->registerExtension(new ConsistenceJmsSerializerExtension());
+
+		foreach ($container->getExtensions() as $extension) {
+			$extension->load([], $container);
+		}
+
+		$serviceId = 'consistence.jms_serializer.enum.enum_serializer_handler';
+		self::assertContainerHasService($container, $serviceId);
+		self::assertContainerServiceIsOfType($container, $serviceId, EnumSerializerHandler::class);
+		self::assertContainerServiceHasTagWithAttributes(
+			$container,
+			$serviceId,
+			'jms_serializer.subscribing_handler',
+			[]
+		);
+
+		$container->compile();
 	}
 
-	public function testRegisterSerializerHandler(): void
+	private static function createContainer(): ContainerBuilder
 	{
-		$this->load();
+		$container = new ContainerBuilder(new ParameterBag([]));
+		$container->getCompilerPassConfig()->setOptimizationPasses([]);
+		$container->getCompilerPassConfig()->setRemovingPasses([]);
+		$container->getCompilerPassConfig()->setAfterRemovingPasses([]);
+
+		return $container;
+	}
 
-		$this->assertContainerBuilderHasService(
-			'consistence.jms_serializer.enum.enum_serializer_handler',
-			EnumSerializerHandler::class
+	private static function assertContainerHasService(ContainerBuilder $container, string $serviceId): void
+	{
+		Assert::assertTrue(
+			$container->has($serviceId),
+			sprintf('Container is missing required service `%s`.', $serviceId)
 		);
-		$this->assertContainerBuilderHasServiceDefinitionWithTag(
-			'consistence.jms_serializer.enum.enum_serializer_handler',
-			'jms_serializer.subscribing_handler'
+	}
+
+	private static function assertContainerServiceIsOfType(
+		ContainerBuilder $container,
+		string $serviceId,
+		string $expectedClassString
+	): void
+	{
+		$serviceDefinition = $container->findDefinition($serviceId);
+
+		Assert::assertSame(
+			$expectedClassString,
+			$container->getParameterBag()->resolveValue($serviceDefinition->getClass())
 		);
+	}
+
+	private static function assertContainerServiceHasTagWithAttributes(
+		ContainerBuilder $container,
+		string $serviceId,
+		string $tagName
+	): void
+	{
+		$tagExists = false;
+		$serviceDefinition = $container->findDefinition($serviceId);
+
+		foreach ($serviceDefinition->getTags() as $name => $tagsAttributes) {
+			if ($name !== $tagName) {
+				continue;
+			}
+
+			$tagExists = true;
+		}
 
-		$this->compile();
+		if (!$tagExists) {
+			Assert::fail(sprintf('Service `%s` does not have any tag `%s`.', $serviceId, $tagName));
+		}
 	}
 
 }