Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda packaging for holoscan latest version (3.x) #28598

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
+429 −0
Draft

conda packaging for holoscan latest version (3.x) #28598

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
620cf20
holoscan 2.6.0.1
billysuh7 Dec 10, 2024
e96cce5
do not split package under output section; use "monolithic" recipe in…
billysuh7 Dec 18, 2024
4feb1a1
add cuda-runtime, and take out many misc dependencies as a result
billysuh7 Jan 9, 2025
937bfdb
Add $PREFIX/python/lib to the sys.path so that holoscan can be loaded…
Jan 24, 2025
c50ca66
add more dependencies
billysuh7 Feb 5, 2025
0a64294
3.0.0.1
billysuh7 Feb 14, 2025
6acc840
split into base, dev and static packages
billysuh7 Feb 17, 2025
7504e6c
update source tarball and add cuda-nvrtc-dev
billysuh7 Feb 18, 2025
90f6a0b
remove lint by specifying feedstock name in the multi-output recipe
billysuh7 Feb 19, 2025
2a4e1c2
take out _openmp_mutex, not needed as dependency
billysuh7 Feb 19, 2025
825fb1a
Updated per review comment and updated source tarball
billysuh7 Feb 22, 2025
b54e588
be explicit about python version
billysuh7 Feb 22, 2025
0f10a50
remove lint by adding stdlib for the compilers
billysuh7 Feb 22, 2025
d7d8a3c
change of package names per request by holoscan team. 1) libholoscan-…
billysuh7 Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions recipes/holoscan/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#!/bin/bash

set -e
set -x

check-glibc bin/* lib/* lib/ucx/* lib/gxf_extensions/*
find python/ -name "*.so*" | xargs -I"{}" check-glibc "{}"

cp -rv bin $PREFIX/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we unpacking a redist instead of building from source when the source is available?

https://github.com/nvidia-holoscan/holoscan-sdk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we already discussed this above back in December 2024.

For gds-tools, onnxruntime and torchvision I will see when we can get respective owners to provide missing DSO, and for TensorRT we'll have to find out a plan for it with respect to conda.

Have you opened issues on the feedstocks for these packages asking for the relevant libraries?

cp -rv examples $PREFIX/
cp -rv lib $PREFIX/
cp -rv include $PREFIX/
cp -rv python $PREFIX/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the pythons unpacked here instead of into site-package?


echo $SP_DIR

# Create the site-packages dir if it doesn't exist
mkdir -p $SP_DIR

# Add a .pth file that references extra directory needed by holoscan
echo "$PREFIX/python/lib" > $SP_DIR/holoscan_extra.pth
38 changes: 38 additions & 0 deletions recipes/holoscan/compile_examples.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#!/bin/bash

set -ex

[[ ${target_platform} == "linux-64" ]] && targetsDir="targets/x86_64-linux"
# https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html?highlight=tegra#cross-compilation
[[ ${target_platform} == "linux-aarch64" && ${arm_variant_type} == "sbsa" ]] && targetsDir="targets/sbsa-linux"
[[ ${target_platform} == "linux-aarch64" && ${arm_variant_type} == "tegra" ]] && targetsDir="targets/aarch64-linux"

if [ -z "${targetsDir+x}" ]; then
echo "target_platform: ${target_platform} is unknown! targetsDir must be defined!" >&2
exit 1
fi

# E.g. $CONDA_PREFIX/libexec/gcc/x86_64-conda-linux-gnu/13.3.0/cc1plus
find $CONDA_PREFIX -name cc1plus

GCC_DIR=$(dirname $(find $CONDA_PREFIX -name cc1plus))

export PATH=${GCC_DIR}:$PATH
export LD_LIBRARY_PATH=${GCC_DIR}:$LD_LIBRARY_PATH

# No need for use-linker-plugin optimization, causes compile failure, don't use it for the test
export CXXFLAGS="${CXXFLAGS} -fno-use-linker-plugin"

echo CC = $CC
echo CXX = $CXX

cmake -S $PREFIX/examples \
-DCMAKE_LIBRARY_PATH=${GCC_DIR} \
-DCMAKE_C_COMPILER=$CC \
-DCMAKE_CXX_COMPILER=$CXX \
-DCUDAToolkit_INCLUDE_DIRECTORIES="$PREFIX/include;$PREFIX/${targetsDir}/include" \
-DCMAKE_PREFIX_PATH=$CONDA_PREFIX \
-DCMAKE_CUDA_COMPILER=$PREFIX/bin/nvcc \
-DCUDAToolkit_ROOT=$PREFIX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try using $CMAKE_ARGS instead of manually setting all of these variables?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this test takes a long time to build all the examples. Something shorter like

cmake -S $PREFIX/examples/hello_world/cpp $CMAKE_ARGS

might be more appropriate.


cmake --build .
2 changes: 2 additions & 0 deletions recipes/holoscan/conda_build_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
c_stdlib_version: # [linux]
- 2.34 # [linux]
Loading
Loading