-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda packaging for holoscan latest version (3.x) #28598
Draft
billysuh7
wants to merge
14
commits into
conda-forge:main
Choose a base branch
from
billysuh7:bsuh/holoscan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+429
−0
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
620cf20
holoscan 2.6.0.1
billysuh7 e96cce5
do not split package under output section; use "monolithic" recipe in…
billysuh7 4feb1a1
add cuda-runtime, and take out many misc dependencies as a result
billysuh7 937bfdb
Add $PREFIX/python/lib to the sys.path so that holoscan can be loaded…
c50ca66
add more dependencies
billysuh7 0a64294
3.0.0.1
billysuh7 6acc840
split into base, dev and static packages
billysuh7 7504e6c
update source tarball and add cuda-nvrtc-dev
billysuh7 90f6a0b
remove lint by specifying feedstock name in the multi-output recipe
billysuh7 2a4e1c2
take out _openmp_mutex, not needed as dependency
billysuh7 825fb1a
Updated per review comment and updated source tarball
billysuh7 b54e588
be explicit about python version
billysuh7 0f10a50
remove lint by adding stdlib for the compilers
billysuh7 d7d8a3c
change of package names per request by holoscan team. 1) libholoscan-…
billysuh7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#!/bin/bash | ||
|
||
set -e | ||
set -x | ||
|
||
# Create the site-packages dir if it doesn't exist | ||
mkdir -p $SP_DIR | ||
|
||
echo "site-packages dir, SP_DIR = $SP_DIR" | ||
|
||
check-glibc bin/* lib/* lib/ucx/* lib/gxf_extensions/* | ||
find python/ -name "*.so*" | xargs -I"{}" check-glibc "{}" | ||
|
||
cp -rv bin $PREFIX/ | ||
cp -rv examples $PREFIX/ | ||
cp -rv lib $PREFIX/ | ||
cp -rv include $PREFIX/ | ||
cp -rv python/lib/* $SP_DIR/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#!/bin/bash | ||
|
||
set -ex | ||
|
||
[[ ${target_platform} == "linux-64" ]] && targetsDir="targets/x86_64-linux" | ||
# https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html?highlight=tegra#cross-compilation | ||
[[ ${target_platform} == "linux-aarch64" && ${arm_variant_type} == "sbsa" ]] && targetsDir="targets/sbsa-linux" | ||
[[ ${target_platform} == "linux-aarch64" && ${arm_variant_type} == "tegra" ]] && targetsDir="targets/aarch64-linux" | ||
|
||
if [ -z "${targetsDir+x}" ]; then | ||
echo "target_platform: ${target_platform} is unknown! targetsDir must be defined!" >&2 | ||
exit 1 | ||
fi | ||
|
||
# E.g. $CONDA_PREFIX/libexec/gcc/x86_64-conda-linux-gnu/13.3.0/cc1plus | ||
find $CONDA_PREFIX -name cc1plus | ||
|
||
GCC_DIR=$(dirname $(find $CONDA_PREFIX -name cc1plus)) | ||
|
||
export PATH=${GCC_DIR}:$PATH | ||
export LD_LIBRARY_PATH=${GCC_DIR}:$LD_LIBRARY_PATH | ||
|
||
# No need for use-linker-plugin optimization, causes compile failure, don't use it for the test | ||
export CXXFLAGS="${CXXFLAGS} -fno-use-linker-plugin" | ||
|
||
echo CC = $CC | ||
echo CXX = $CXX | ||
|
||
CMAKE_ARGS="-DCMAKE_LIBRARY_PATH=${GCC_DIR} \ | ||
-DCMAKE_C_COMPILER=$CC \ | ||
-DCMAKE_CXX_COMPILER=$CXX \ | ||
-DCUDAToolkit_INCLUDE_DIRECTORIES=\"$PREFIX/include;$PREFIX/${targetsDir}/include\" \ | ||
-DCMAKE_PREFIX_PATH=$CONDA_PREFIX \ | ||
-DCMAKE_CUDA_COMPILER=$PREFIX/bin/nvcc \ | ||
-DCUDAToolkit_ROOT=$PREFIX" | ||
|
||
cmake -S $PREFIX/examples ${CMAKE_ARGS} | ||
|
||
cmake --build . |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
c_stdlib_version: # [linux] | ||
- 2.34 # [linux] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we unpacking a redist instead of building from source when the source is available?
https://github.com/nvidia-holoscan/holoscan-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we already discussed this above back in December 2024.
Have you opened issues on the feedstocks for these packages asking for the relevant libraries?