Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bridge: add test cases for MSGQ-to-ZMQ bridge #34825

Closed
wants to merge 2 commits into from
Closed

bridge: add test cases for MSGQ-to-ZMQ bridge #34825

wants to merge 2 commits into from
+124 −3

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Mar 9, 2025 •
edited
Loading

Adds test cases to validate the core functionality of the MSGQ-to-ZMQ bridge:

  1. Initialization: Confirms the bridge correctly sets up socket pairs for the endpoints.
  2. Subscriber Connection: Verifies that MSGQ subscriber sockets are created on demand when a ZMQ client connects.
  3. Message Forwarding: Ensures successful transmission and reception of messages.
  4. Order Preservation: Confirms messages are received in the order they were sent.
  5. Subscriber Disconnect: Validates that MSGQ sockets are released when the ZMQ subscriber disconnects.
  6. Sleep Mode: Verifies the bridge enters sleep mode when no ZMQ subscribers are active.

resolve: commaai/msgq#319

@deanlee deanlee changed the title bridge: add comprehensive test coverage for MSGQ-to-ZMQ bridge bridge: add test cases for core functionality of MSGQ-to-ZMQ bridge Mar 9, 2025
@deanlee deanlee force-pushed the bridge_testcase branch 3 times, most recently from 5558b88 to 4dff4d7 Compare March 9, 2025 12:08
@deanlee deanlee marked this pull request as ready for review March 9, 2025 16:02
@deanlee deanlee changed the title bridge: add test cases for core functionality of MSGQ-to-ZMQ bridge bridge: add test cases for MSGQ-to-ZMQ bridge Mar 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Mar 20, 2025
deanlee added 2 commits March 20, 2025 10:57
@deanlee
add test case
a91c7bd
@deanlee
pop_back on failure
Loading
Loading status checks…
4d0ac99
@github-actions github-actions bot removed the stale label Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Mar 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests around bridge
1 participant
@deanlee