pop_back on failure

deanlee · deanlee · commit 32c4bf0be8a8 · 2025-03-09T21:14:01.000+08:00
diff --git a/cereal/messaging/msgq_to_zmq.cc b/cereal/messaging/msgq_to_zmq.cc
@@ -32,6 +32,7 @@ void MsgqToZmq::run(const std::vector<std::string> &endpoints, const std::string
     int ret = socket_pair.pub_sock->connect(zmq_context.get(), endpoint);
     if (ret != 0) {
       printf("Failed to create ZMQ publisher for [%s]: %s\n", endpoint.c_str(), zmq_strerror(zmq_errno()));
+      socket_pairs.pop_back();  // Roll back on failure
       return;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ void MsgqToZmq::run(const std::vector<std::string> &endpoints, const std::string`
`32`	`32`	`int ret = socket_pair.pub_sock->connect(zmq_context.get(), endpoint);`
`33`	`33`	`if (ret != 0) {`
`34`	`34`	`printf("Failed to create ZMQ publisher for [%s]: %s\n", endpoint.c_str(), zmq_strerror(zmq_errno()));`
	`35`	`+ socket_pairs.pop_back(); // Roll back on failure`
`35`	`36`	`return;`
`36`	`37`	`}`
`37`	`38`	`}`