Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Fix minor bug in getmatrix #53

Open
ironmaniiith wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix minor bug in getmatrix #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/plone/importexport/browser/importexport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,10 +712,12 @@ def getmatrix(self, headers=None, columns=4):

matrix = {}
count = len(headers)
rows = float(count / columns)
rows = float(count) / columns

if isinstance(rows, float):
Copy link
Copy Markdown
Contributor Author

@ironmaniiith ironmaniiith Jun 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rows is always an instance of float. Hence this conditional statement doesn't work

if rows != int(rows):
rows = int(rows) + 1
else:
rows = int(rows)

for index in range(rows):
matrix[index] = []
Expand Down