This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Open
Conversation
ironmaniiith
commented
Jun 23, 2019
| rows = float(count / columns) | ||
| rows = float(count) / columns | ||
|
|
||
| if isinstance(rows, float): |
Contributor
Author
There was a problem hiding this comment.
rows is always an instance of float. Hence this conditional statement doesn't work
Member
|
If you find a bug then add a test that detects that bug. It's esp good to checkin the test before fixing the code to show in the CI that the test fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code fails when
countis a multiple ofcolumns. Also the if condition here always evaluates toTrueand doesn't solve it's purpose as expected here